chore: cleanup TODO comments (#284)

cmoog · web-flow · commit 9ff25a237200 · 2021-03-11T21:54:17.000Z
diff --git a/ci/integration/tags_test.go b/ci/integration/tags_test.go
@@ -31,7 +31,5 @@ func TestTags(t *testing.T) {
 			tcli.StdoutJSONUnmarshal(&tags),
 		)
 		assert.True(t, "> 0 tags", len(tags) > 0)
-
-		// TODO(@cmoog) add create and rm integration tests
 	})
 }
diff --git a/internal/cmd/rebuild.go b/internal/cmd/rebuild.go
@@ -124,7 +124,7 @@ func trailBuildLogs(ctx context.Context, client coder.Client, envID string) erro
 			s.Start()
 
 		case coder.BuildLogTypeSubstage:
-			// TODO(@cmoog) add verbose substage printing
+			// TODO(@f0ssel) add verbose substage printing
 			if !verbose {
 				continue
 			}
diff --git a/internal/cmd/resourcemanager.go b/internal/cmd/resourcemanager.go
@@ -310,12 +310,6 @@ func (a resources) String() string {
 		"[cpu: alloc=%.1fvCPU]\t[mem: alloc=%.1fGB]",
 		a.cpuAllocation, a.memAllocation,
 	)
-
-	// TODO@cmoog: consider adding the utilization info once a historical average is considered or implemented
-	// return fmt.Sprintf(
-	// 	"[cpu: alloc=%.1fvCPU, util=%s]\t[mem: alloc=%.1fGB, util=%s]",
-	// 	a.cpuAllocation, a.cpuUtilPercentage(), a.memAllocation, a.memUtilPercentage(),
-	// )
 }
 
 //nolint:unused

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,5 @@ func TestTags(t *testing.T) {`
`31`	`31`	`tcli.StdoutJSONUnmarshal(&tags),`
`32`	`32`	`)`
`33`	`33`	`assert.True(t, "> 0 tags", len(tags) > 0)`
`34`		`-`
`35`		`- // TODO(@cmoog) add create and rm integration tests`
`36`	`34`	`})`
`37`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ func trailBuildLogs(ctx context.Context, client coder.Client, envID string) erro`
`124`	`124`	`s.Start()`
`125`	`125`
`126`	`126`	`case coder.BuildLogTypeSubstage:`
`127`		`- // TODO(@cmoog) add verbose substage printing`
	`127`	`+ // TODO(@f0ssel) add verbose substage printing`
`128`	`128`	`if !verbose {`
`129`	`129`	`continue`
`130`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -310,12 +310,6 @@ func (a resources) String() string {`
`310`	`310`	`"[cpu: alloc=%.1fvCPU]\t[mem: alloc=%.1fGB]",`
`311`	`311`	`a.cpuAllocation, a.memAllocation,`
`312`	`312`	`)`
`313`		`-`
`314`		`- // TODO@cmoog: consider adding the utilization info once a historical average is considered or implemented`
`315`		`- // return fmt.Sprintf(`
`316`		`- // "[cpu: alloc=%.1fvCPU, util=%s]\t[mem: alloc=%.1fGB, util=%s]",`
`317`		`- // a.cpuAllocation, a.cpuUtilPercentage(), a.memAllocation, a.memUtilPercentage(),`
`318`		`- // )`
`319`	`313`	`}`
`320`	`314`
`321`	`315`	`//nolint:unused`