bug: fix an issue where query parameters weren't being added to the request

sreya · sreya · commit b823a18805f5 · 2021-01-15T00:30:40.000-06:00
diff --git a/coder-sdk/request.go b/coder-sdk/request.go
@@ -28,6 +28,12 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}
 		url = *config.BaseURLOverride
 	}
 
+	url.Path = path
+
+	if config.Query != nil {
+		url.RawQuery = config.Query.Encode()
+	}
+
 	// If we have incoming data, encode it as json.
 	var payload io.Reader
 	if in != nil {
@@ -39,7 +45,7 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}
 	}
 
 	// Create the http request.
-	req, err := http.NewRequestWithContext(ctx, method, url.String()+path, payload)
+	req, err := http.NewRequestWithContext(ctx, method, url.String(), payload)
 	if err != nil {
 		return nil, xerrors.Errorf("create request: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,12 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}`
`28`	`28`	`url = *config.BaseURLOverride`
`29`	`29`	`}`
`30`	`30`
	`31`	`+ url.Path = path`
	`32`	`+`
	`33`	`+ if config.Query != nil {`
	`34`	`+ url.RawQuery = config.Query.Encode()`
	`35`	`+ }`
	`36`	`+`
`31`	`37`	`// If we have incoming data, encode it as json.`
`32`	`38`	`var payload io.Reader`
`33`	`39`	`if in != nil {`
`@@ -39,7 +45,7 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}`
`39`	`45`	`}`
`40`	`46`
`41`	`47`	`// Create the http request.`
`42`		`- req, err := http.NewRequestWithContext(ctx, method, url.String()+path, payload)`
	`48`	`+ req, err := http.NewRequestWithContext(ctx, method, url.String(), payload)`
`43`	`49`	`if err != nil {`
`44`	`50`	`return nil, xerrors.Errorf("create request: %w", err)`
`45`	`51`	`}`