Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Commit c057c38

Browse files
committed
coder: remove some unnecessary SSH settings
- Removed ServerAliveInterval and ServerAliveCountMax from config-ssh settings. These settings can cause idle SSH sessions to disconnect and should be inherited from the user's global settings. 'coder config-ssh' should only write configuration options that are necessary for 'coder sh' and its variants to succeed.
1 parent 74d0294 commit c057c38

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

cmd/coder/wac.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
version: 0.2
2+
workspace:
3+
type: "kubernetes"
4+
specs:
5+
kubernetes:
6+
image:
7+
value: "index.docker.io/ubuntu"
8+
container-based-vm:
9+
value: false
10+
cpu:
11+
value: 1
12+
memory:
13+
value: 1
14+
disk:
15+
value: 30
16+
labels:
17+
value:
18+
coder: "woohoo"
19+
wac: "hooray"
20+
env:
21+
value:
22+
- key: TEST_ME
23+
value: "hooray"
24+
- key: TEST2
25+
value: "yippee"

internal/cmd/configssh.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,6 @@ func makeSSHConfig(host, userName, workspaceName, privateKeyFilepath string, tun
230230
ConnectTimeout=0
231231
IdentitiesOnly yes
232232
IdentityFile="%s"
233-
ServerAliveInterval 60
234-
ServerAliveCountMax 3
235233
`, workspaceName, workspaceName, workspaceName, privateKeyFilepath)
236234
}
237235

@@ -243,8 +241,6 @@ func makeSSHConfig(host, userName, workspaceName, privateKeyFilepath string, tun
243241
ConnectTimeout=0
244242
IdentitiesOnly yes
245243
IdentityFile="%s"
246-
ServerAliveInterval 60
247-
ServerAliveCountMax 3
248244
`, workspaceName, host, userName, workspaceName, privateKeyFilepath)
249245
}
250246

0 commit comments

Comments
 (0)