bug: fix an issue where query parameters weren't being added to the request (#219)

sreya · web-flow · commit e52bd24dd6de · 2021-01-15T01:07:10.000-06:00
diff --git a/coder-sdk/request.go b/coder-sdk/request.go
@@ -27,6 +27,11 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}
 	if config.BaseURLOverride != nil {
 		url = *config.BaseURLOverride
 	}
+	if config.Query != nil {
+		url.RawQuery = config.Query.Encode()
+	}
+
+	url.Path = path
 
 	// If we have incoming data, encode it as json.
 	var payload io.Reader
@@ -39,7 +44,7 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}
 	}
 
 	// Create the http request.
-	req, err := http.NewRequestWithContext(ctx, method, url.String()+path, payload)
+	req, err := http.NewRequestWithContext(ctx, method, url.String(), payload)
 	if err != nil {
 		return nil, xerrors.Errorf("create request: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,11 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}`
`27`	`27`	`if config.BaseURLOverride != nil {`
`28`	`28`	`url = *config.BaseURLOverride`
`29`	`29`	`}`
	`30`	`+ if config.Query != nil {`
	`31`	`+ url.RawQuery = config.Query.Encode()`
	`32`	`+ }`
	`33`	`+`
	`34`	`+ url.Path = path`
`30`	`35`
`31`	`36`	`// If we have incoming data, encode it as json.`
`32`	`37`	`var payload io.Reader`
`@@ -39,7 +44,7 @@ func (c Client) request(ctx context.Context, method, path string, in interface{}`
`39`	`44`	`}`
`40`	`45`
`41`	`46`	`// Create the http request.`
`42`		`- req, err := http.NewRequestWithContext(ctx, method, url.String()+path, payload)`
	`47`	`+ req, err := http.NewRequestWithContext(ctx, method, url.String(), payload)`
`43`	`48`	`if err != nil {`
`44`	`49`	`return nil, xerrors.Errorf("create request: %w", err)`
`45`	`50`	`}`