Update [vV]ersion comment strings; remove extraneous error check.

stephenwithav · stephenwithav · commit e8abef25061e · 2020-07-02T11:17:32.000-04:00
diff --git a/cmd/coder/sync.go b/cmd/coder/sync.go
@@ -33,7 +33,7 @@ func (cmd *syncCmd) RegisterFlags(fl *pflag.FlagSet) {
 	fl.BoolVarP(&cmd.init, "init", "i", false, "do initial transfer and exit")
 }
 
-// Returns local rsync protocol version as a string.
+// version returns local rsync protocol version as a string.
 func (_ *syncCmd) version() string {
 	cmd := exec.Command("rsync", "--version")
 	out, err := cmd.CombinedOutput()
diff --git a/internal/sync/sync.go b/internal/sync/sync.go
@@ -263,7 +263,7 @@ const (
 	maxAcceptableDispatch = time.Millisecond * 50
 )
 
-// Returns remote protocol version as a string.
+// Version returns remote protocol version as a string.
 // Or, an error if one exists.
 func (s Sync) Version() (string, error) {
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*10)
@@ -287,9 +287,6 @@ func (s Sync) Version() (string, error) {
 	io.Copy(buf, process.Stdout())
 
 	err = process.Wait()
-	if _, ok := err.(wsep.ExitError); ok {
-		return "", err
-	}
 	if err != nil {
 		return "", err
 	}

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func (cmd syncCmd) RegisterFlags(fl pflag.FlagSet) {`
`33`	`33`	`fl.BoolVarP(&cmd.init, "init", "i", false, "do initial transfer and exit")`
`34`	`34`	`}`
`35`	`35`
`36`		`-// Returns local rsync protocol version as a string.`
	`36`	`+// version returns local rsync protocol version as a string.`
`37`	`37`	`func (_ *syncCmd) version() string {`
`38`	`38`	`cmd := exec.Command("rsync", "--version")`
`39`	`39`	`out, err := cmd.CombinedOutput()`