fixup! Add new clog.ErrGroup

cmoog · cmoog · commit eb618aa46e3b · 2020-10-25T11:38:50.000-05:00
diff --git a/internal/clog/errgroup.go b/internal/clog/errgroup.go
@@ -12,7 +12,8 @@ import (
 //
 // Take for example, a case in which we are concurrently stopping a slice of environments.
 // In this case, we want to log errors as they happen, not pass them through the callstack as errors.
-// When the operations complete, we want to log how many, if any, failed.
+// When the operations complete, we want to log how many, if any, failed. The caller is still expected
+// to handle success and info logging.
 type ErrGroup interface {
 	Go(f func() error)
 	Wait() error
@@ -23,8 +24,8 @@ type group struct {
 	failures int32
 }
 
-// NewErrGroup gives an error group with logging and error propagation handled automatically.
-func NewErrGroup() ErrGroup {
+// LoggedErrGroup gives an error group with error logging and error propagation handled automatically.
+func LoggedErrGroup() ErrGroup {
 	return &group{
 		egroup:   errgroup.Group{},
 		failures: 0,
diff --git a/internal/cmd/envs.go b/internal/cmd/envs.go
@@ -100,7 +100,7 @@ coder envs --user charlie@coder.com ls -o json \
 				return xerrors.Errorf("new client: %w", err)
 			}
 
-			egroup := clog.NewErrGroup()
+			egroup := clog.LoggedErrGroup()
 			for _, envName := range args {
 				envName := envName
 				egroup.Go(func() error {

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ coder envs --user charlie@coder.com ls -o json \`
`100`	`100`	`return xerrors.Errorf("new client: %w", err)`
`101`	`101`	`}`
`102`	`102`
`103`		`- egroup := clog.NewErrGroup()`
	`103`	`+ egroup := clog.LoggedErrGroup()`
`104`	`104`	`for _, envName := range args {`
`105`	`105`	`envName := envName`
`106`	`106`	`egroup.Go(func() error {`