From aec797dbcc95392f84a33d5589031acce0d4febd Mon Sep 17 00:00:00 2001 From: Charlie Moog Date: Thu, 11 Mar 2021 15:47:19 -0600 Subject: [PATCH] chore: cleanup TODO comments --- ci/integration/tags_test.go | 2 -- internal/cmd/rebuild.go | 2 +- internal/cmd/resourcemanager.go | 6 ------ 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/ci/integration/tags_test.go b/ci/integration/tags_test.go index fdeabbb4..d4f0158c 100644 --- a/ci/integration/tags_test.go +++ b/ci/integration/tags_test.go @@ -31,7 +31,5 @@ func TestTags(t *testing.T) { tcli.StdoutJSONUnmarshal(&tags), ) assert.True(t, "> 0 tags", len(tags) > 0) - - // TODO(@cmoog) add create and rm integration tests }) } diff --git a/internal/cmd/rebuild.go b/internal/cmd/rebuild.go index 80be84b9..bf998b40 100644 --- a/internal/cmd/rebuild.go +++ b/internal/cmd/rebuild.go @@ -124,7 +124,7 @@ func trailBuildLogs(ctx context.Context, client coder.Client, envID string) erro s.Start() case coder.BuildLogTypeSubstage: - // TODO(@cmoog) add verbose substage printing + // TODO(@f0ssel) add verbose substage printing if !verbose { continue } diff --git a/internal/cmd/resourcemanager.go b/internal/cmd/resourcemanager.go index 01f4875c..c3ea1c22 100644 --- a/internal/cmd/resourcemanager.go +++ b/internal/cmd/resourcemanager.go @@ -310,12 +310,6 @@ func (a resources) String() string { "[cpu: alloc=%.1fvCPU]\t[mem: alloc=%.1fGB]", a.cpuAllocation, a.memAllocation, ) - - // TODO@cmoog: consider adding the utilization info once a historical average is considered or implemented - // return fmt.Sprintf( - // "[cpu: alloc=%.1fvCPU, util=%s]\t[mem: alloc=%.1fGB, util=%s]", - // a.cpuAllocation, a.cpuUtilPercentage(), a.memAllocation, a.memUtilPercentage(), - // ) } //nolint:unused