Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Show network error on unexpected disconnect #88

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Show network error on unexpected disconnect #88

merged 1 commit into from
Aug 3, 2020

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Aug 3, 2020

This is a hotfix for a common shell disconnect case. Future enhancements will poll for the environment status and display a more actionable message.
Progress towards #87

$ coder sh development
2020-08-03 09:55:21 FATAL	run command: network error, is "development" online?

@cmoog cmoog requested a review from wbobeirne August 3, 2020 14:57
Copy link

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely seems like an improvement

@cmoog cmoog merged commit 13fb3ca into master Aug 3, 2020
@cmoog cmoog deleted the close-err branch August 3, 2020 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants