Skip to content

add Coder capabilities doc for code-server users #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 6, 2021
Merged

add Coder capabilities doc for code-server users #161

merged 15 commits into from
Apr 6, 2021

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Mar 15, 2021

This is a draft page that code-server users will get recommended if they are running code-server in Kubernetes. Would love feedback on:

  • should this live in /guides in docs?
  • format
  • are these the correct capabilities? goal is to highlight Coder features for those doing a DIY code-server + K8s project and are unfamiliar with Coder
  • if/how we should incorporate this with the comparison doc, which focuses on standalone code-server

@bpmct bpmct marked this pull request as draft March 15, 2021 16:20
@khorne3
Copy link
Contributor

khorne3 commented Mar 15, 2021

@bpmct I'm a bit confused, so I was hoping you could clarify the messaging; is this doc targeting users who have a DIY code-server setup they're hosting on K8 where we basically say, "Hey, here's what you would get if you used the full Coder deployment?"

@bpmct
Copy link
Member Author

bpmct commented Mar 15, 2021

@bpmct I'm a bit confused, so I was hoping you could clarify the messaging; is this doc targeting users who have a DIY code-server setup they're hosting on K8 where we basically say, "Hey, here's what you would get if you used the full Coder deployment?"

Yes exactly, and I'd love feedback on how this could me more clear. A decent number of people attempt to build code-server on Kubernetes without knowledge of Coder's existence. Many of the things highlighted in this page are complex to implement in a DIY solution, but may be necessary for a user.

@khorne3
Copy link
Contributor

khorne3 commented Mar 17, 2021

I reworded things a bit to hopefully be clearer. I'm also thinking about sticking it under About > Comparison?

ashumz
ashumz reviewed Mar 23, 2021
View reviewed changes
ashumz
ashumz reviewed Mar 23, 2021
View reviewed changes
bpmct and others added 3 commits March 24, 2021 09:33
@bpmct @ashumz
Update guides/code-server-envs.md
4bccc9f 
Co-authored-by: Ashley McClelland <armcclelland@gmail.com>
@bpmct @ashumz
Update guides/code-server-envs.md
c4de7ab 
Co-authored-by: Ashley McClelland <armcclelland@gmail.com>
@github-actions
Auto-merged master into refs/heads/code-server-k8s on deployment.
69612d5
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2021 •
edited
Loading

✨ Coder.com for PR #161 deployed! It will be updated on every commit.

kylecarbs
kylecarbs approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to the manifest, but LGTM!

@khorne3
Copy link
Contributor

khorne3 commented Mar 29, 2021

Latest changes:

  • Moved to Guides/Deployments
  • Simplified URL
  • Added doc to manifest.json

@greyscaled greyscaled added docs 📝 Improvements or additions to documentation enhancement ✨ New feature or request labels Mar 30, 2021
@bpmct bpmct marked this pull request as ready for review April 2, 2021 16:13
@bpmct bpmct merged commit 417a8cc into master Apr 6, 2021
@bpmct bpmct deleted the code-server-k8s branch April 6, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashumz ashumz ashumz left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

@nathanpotter nathanpotter Awaiting requested review from nathanpotter

@khorne3 khorne3 Awaiting requested review from khorne3

Assignees

@bpmct bpmct

Labels
docs 📝 Improvements or additions to documentation enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bpmct @khorne3 @ashumz @kylecarbs @greyscaled