Skip to content

update letsencrypt server URL to prod #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2021
Merged

update letsencrypt server URL to prod #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc4c68
update letsencrypt server URL to prod
ericpaulsen Jul 6, 2021
d388cb7
fix: devurls host name
ericpaulsen Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guides/ssl-certificates/azureDNS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ following `helm install` command instead:
```console
helm install coder coder/coder --namespace coder \
--version=<CODER_VERSION> \
--set devurls.host="*.exampleCo.com" \
--set devurls.host="*.coder.exampleCo.com" \
--set ingress.host="coder.exampleCo.com" \
--set ingress.tls.enable=true \
--set ingress.tls.devurlsHostSecretName=coder-devurls-cert \
Expand Down
4 changes: 2 additions & 2 deletions guides/ssl-certificates/route53.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ To make sure that your `clusterIssuer` can change your DNS settings,
preferredChain: ""
privateKeySecretRef:
name: example-issuer-account-key
server: https://acme-staging-v02.api.letsencrypt.org/directory
server: https://acme-v02.api.letsencrypt.org/directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide examples for both? I imagine that someone would want to test with staging first, and then switch to production once they confirm it works, because I think the rate limits are different between staging and prod?

Copy link
Member Author

@ericpaulsen ericpaulsen Jul 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - the rate limits are different. See here. I'm in favor of including an example for each, so users are aware of both options and can decide for themselves.

solvers:
- dns01:
route53:
Expand Down Expand Up @@ -139,7 +139,7 @@ following `helm install` command instead:
```console
helm install coder coder/coder --namespace coder \
--version=<CODER_VERSION> \
--set devurls.host="*.exampleCo.com" \
--set devurls.host="*.coder.exampleCo.com" \
--set ingress.host="coder.exampleCo.com" \
--set ingress.tls.enable=true \
--set ingress.tls.devurlsHostSecretName=coder-devurls-cert \
Expand Down