check for 404s and 500s on previews #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #601 deployed! It will be updated on every commit.
|
jawnsy
reviewed
Sep 14, 2021
| - name: Install node_modules | ||
| run: yarn install | ||
| - name: Check docs | ||
| run: yarn ts-node ./product/coder.com/site/scripts/checkDocs.ts |
There was a problem hiding this comment.
IMHO it's a little clearer to use yarn run ts-node because people less familiar with Node might not be familiar with this behavior.
I'd also suggest putting this at the end of the build (after comment credentials) so that people can see the link to the preview. Otherwise, people won't be able to easily inspect the deployment (needed if you want to open the Vercel console and watch the function logs while you bring up the docs site)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.