Skip to content

Orgs: User admins should not see UI to edit or create roles in the UI #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaaydenh opened this issue Feb 24, 2025 · 0 comments · Fixed by coder/coder#16854
Closed

Orgs: User admins should not see UI to edit or create roles in the UI #428

jaaydenh opened this issue Feb 24, 2025 · 0 comments · Fixed by coder/coder#16854
Assignees
@jaaydenh
Milestone
Orgs & Custom Rol...

Comments

@jaaydenh
Copy link

Org and site-wide user admins do not have permissions to create or edit roles and therefore it doesn't make sense to see UI to let them attempt to do this in the UI.

Open question: Should we show the delete button?

Image
Image
@jaaydenh jaaydenh self-assigned this Feb 25, 2025
@jaaydenh jaaydenh mentioned this issue Mar 7, 2025
Merged
EdwardAngert pushed a commit to coder/coder that referenced this issue Mar 18, 2025
@jaaydenh @EdwardAngert
fix: use correct permissions for CRUD of custom roles (#16854)
646fe82 
resolves coder/internal#428

The goal of the PR is to start using updateOrgRoles and deleteOrgRoles
permissions to gate custom roles functionality

```
		updateOrgRoles: {
			object: {
				resource_type: "assign_org_role",
				organization_id: organizationId,
			},
			action: "update",
		},
		deleteOrgRoles: {
			object: {
				resource_type: "assign_org_role",
				organization_id: organizationId,
			},
			action: "delete",
		}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
Orgs & Custom Roles Enhancements
Development

Successfully merging a pull request may close this issue.

fix: use correct permissions for CRUD of custom roles coder/coder
1 participant
@jaaydenh