Skip to content

flake: TestAgent_Stats_Magic #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Apr 8, 2025 · 0 comments · Fixed by coder/coder#17290
Closed

flake: TestAgent_Stats_Magic #564

spikecurtis opened this issue Apr 8, 2025 · 0 comments · Fixed by coder/coder#17290
Assignees
@spikecurtis
Labels
flake

Comments

@spikecurtis
Copy link 

     agent_test.go:191: got stats: ok=true, ConnectionCount=0, RxBytes=0, TxBytes=0, SessionCountVSCode=1, ConnectionMedianLatencyMS=0.381000
    t.go:106: 2025-04-07 07:47:24.914 [debu]  client.net.wgengine: netcheck: [v1] netcheck: measuring HTTP(S) latency of test (1): unexpected status code: 426 (426 Upgrade Required)
    t.go:106: 2025-04-07 07:47:24.914 [debu]  client.net.wgengine: netcheck: [v1] report: udp=true v6=false v6os=true mapvarydest=false hair=true portmap= v4a=127.0.0.1:56495 derp=0
    agent_test.go:189: 
        	Error Trace:	/Users/runner/work/coder/coder/agent/agent_test.go:189
        	Error:      	Condition never satisfied
        	Test:       	TestAgent_Stats_Magic/TracksVSCode
        	Messages:   	never saw stats

https://github.com/coder/coder/actions/runs/14303616317/job/40082574718
@spikecurtis spikecurtis self-assigned this Apr 8, 2025
@spikecurtis spikecurtis mentioned this issue Apr 8, 2025
Merged
spikecurtis added a commit to coder/coder that referenced this issue Apr 8, 2025
@spikecurtis
fix: stop checking gauges unrelated to TestAgent_Stats_Magic (#17290)
b1f59aa 
Fixes coder/internal#564

The test is asserting too much, including stats guages that are not directly related to the thing we are trying to test: ConnectionCount, RxBytes, and TxBytes.  I think the author assumed that these are counts that only go up, but they are guages and eventually zero back out, so there are race condtions where not all of them are non-zero at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop checking gauges unrelated to TestAgent_Stats_Magic coder/coder
1 participant
@spikecurtis