Skip to content

site: display warning when the chosen IDP role, group or org in the table does not match an existing claim field value #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kira-Pilot opened this issue Sep 27, 2024 · 0 comments · Fixed by coder/coder#16485
Closed

site: display warning when the chosen IDP role, group or org in the table does not match an existing claim field value #82

Kira-Pilot opened this issue Sep 27, 2024 · 0 comments · Fixed by coder/coder#16485
Assignees
@aslilac
Labels
coder-ui Frontend tasks for coder/coder
Milestone
Orgs GA

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Sep 27, 2024 •
edited by jaaydenh
Loading

The goal of this task is to display a warning indicator/message next to the IDP role, group or org name in the table if that value does not exist in the claim field values as returned from the API.

The claim field values API expects a claim field and the simplest way to provide that is to use the value entered in the sync field.

The error message could be something like "org/group/role claims field does not exist".

See idpSyncClaimFieldValues API here
https://github.com/coder/coder/blob/951a8ed98df5f1da1cce9fd6ab10a1d4828059cf/enterprise/coderd/idpsync.go#L811

Figma Link: https://www.figma.com/design/DDdfRMoFIvJo1XkxW1lW11/Idp-Organizations-Sync-Wireframe?node-id=164-2057&t=yUGGOWwHtqshj6PQ-1

Image
@Emyrk Emyrk mentioned this issue Jan 6, 2025
Closed
@jaaydenh jaaydenh changed the title site: display IdP sync warnings on IdP UI site: display warning when the chosen IDP role, group or org in the table does not match an existing claim field value Jan 24, 2025
@jaaydenh jaaydenh self-assigned this Jan 24, 2025
@jaaydenh jaaydenh added the coder-ui Frontend tasks for coder/coder label Jan 24, 2025
@Kira-Pilot Kira-Pilot assigned aslilac and unassigned jaaydenh Feb 3, 2025
This was referenced Feb 6, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
coder-ui Frontend tasks for coder/coder
Projects
None yet
Milestone
Orgs GA
Development

Successfully merging a pull request may close this issue.

feat: show warning on unrecognized idp group and role mapping claims coder/coder
4 participants
@aslilac @jaaydenh @matifali @Kira-Pilot