Fix: disable next button when no workspace is selected

fioan89 · fioan89 · commit 278a0b66f214 · 2022-08-10T00:29:35.000+03:00
- resolves #60
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 
 - left panel is no longer visible when a new connection is triggered from Coder's "Recent Workspaces" panel.
   This provides consistency with other plugins compatible with Gateway
+- the "Select IDE and Project" button in the "Coder Workspaces" view is now disabled when no workspace is selected
 
 ### Changed
 
diff --git a/src/main/kotlin/com/coder/gateway/views/CoderGatewayConnectorWizardView.kt b/src/main/kotlin/com/coder/gateway/views/CoderGatewayConnectorWizardView.kt
@@ -29,7 +29,7 @@ class CoderGatewayConnectorWizardView : BorderLayoutPanel(), Disposable {
     private fun setupWizard() {
         background = WelcomeScreenUIManager.getMainAssociatedComponentBackground()
 
-        registerStep(CoderWorkspacesStepView())
+        registerStep(CoderWorkspacesStepView { nextButton.isEnabled = it })
         registerStep(CoderLocateRemoteProjectStepView {
             nextButton.isVisible = false
         })
diff --git a/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt b/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
@@ -59,7 +59,7 @@ import javax.swing.table.DefaultTableCellRenderer
 import javax.swing.table.TableCellRenderer
 
 
-class CoderWorkspacesStepView : CoderWorkspacesWizardStep, Disposable {
+class CoderWorkspacesStepView(val enableNextButtonCallback: (Boolean) -> Unit) : CoderWorkspacesWizardStep, Disposable {
     private val cs = CoroutineScope(Dispatchers.Main)
     private var wizardModel = CoderWorkspacesWizardModel()
     private val coderClient: CoderRestClientService = ApplicationManager.getApplication().getService(CoderRestClientService::class.java)
@@ -77,6 +77,9 @@ class CoderWorkspacesStepView : CoderWorkspacesWizardStep, Disposable {
         }
 
         setSelectionMode(ListSelectionModel.SINGLE_SELECTION)
+        selectionModel.addListSelectionListener {
+            enableNextButtonCallback(selectedObject != null)
+        }
     }
 
     override val component = panel {
@@ -118,6 +121,7 @@ class CoderWorkspacesStepView : CoderWorkspacesWizardStep, Disposable {
     override val nextActionText = CoderGatewayBundle.message("gateway.connector.view.coder.workspaces.next.text")
 
     override fun onInit(wizardModel: CoderWorkspacesWizardModel) {
+        enableNextButtonCallback(false)
     }
 
     private fun loginAndLoadWorkspace() {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ import javax.swing.table.DefaultTableCellRenderer`
`59`	`59`	`import javax.swing.table.TableCellRenderer`
`60`	`60`
`61`	`61`
`62`		`-class CoderWorkspacesStepView : CoderWorkspacesWizardStep, Disposable {`
	`62`	`+class CoderWorkspacesStepView(val enableNextButtonCallback: (Boolean) -> Unit) : CoderWorkspacesWizardStep, Disposable {`
`63`	`63`	`private val cs = CoroutineScope(Dispatchers.Main)`
`64`	`64`	`private var wizardModel = CoderWorkspacesWizardModel()`
`65`	`65`	`private val coderClient: CoderRestClientService = ApplicationManager.getApplication().getService(CoderRestClientService::class.java)`
`@@ -77,6 +77,9 @@ class CoderWorkspacesStepView : CoderWorkspacesWizardStep, Disposable {`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`setSelectionMode(ListSelectionModel.SINGLE_SELECTION)`
	`80`	`+ selectionModel.addListSelectionListener {`
	`81`	`+ enableNextButtonCallback(selectedObject != null)`
	`82`	`+ }`
`80`	`83`	`}`
`81`	`84`
`82`	`85`	`override val component = panel {`
`@@ -118,6 +121,7 @@ class CoderWorkspacesStepView : CoderWorkspacesWizardStep, Disposable {`
`118`	`121`	`override val nextActionText = CoderGatewayBundle.message("gateway.connector.view.coder.workspaces.next.text")`
`119`	`122`
`120`	`123`	`override fun onInit(wizardModel: CoderWorkspacesWizardModel) {`
	`124`	`+ enableNextButtonCallback(false)`
`121`	`125`	`}`
`122`	`126`
`123`	`127`	`private fun loginAndLoadWorkspace() {`