impl: check if Coder version is in range

fioan89 · fioan89 · commit 91ce5514e317 · 2022-12-09T22:43:17.000+02:00
- compare if version is in between min&amp;max supported
  versions of Coder
diff --git a/src/main/kotlin/com/coder/gateway/CoderSupportedVersions.kt b/src/main/kotlin/com/coder/gateway/CoderSupportedVersions.kt
@@ -9,6 +9,7 @@ import org.jetbrains.annotations.PropertyKey
 private const val BUNDLE = "version.CoderSupportedVersions"
 
 object CoderSupportedVersions : DynamicBundle(BUNDLE) {
+    val minCompatibleCoderVersion = CoderSemVer.parse(message("minCompatibleCoderVersion"))
     val maxCompatibleCoderVersion = CoderSemVer.parse(message("maxCompatibleCoderVersion"))
 
     @JvmStatic
diff --git a/src/main/kotlin/com/coder/gateway/sdk/CoderSemVer.kt b/src/main/kotlin/com/coder/gateway/sdk/CoderSemVer.kt
@@ -9,6 +9,7 @@ class CoderSemVer(private val major: Long = 0, private val minor: Long = 0, priv
         require(patch >= 0) { "Coder minor version must be a positive number" }
     }
 
+    fun isInClosedRange(start: CoderSemVer, endInclusive: CoderSemVer) = this in start..endInclusive
     fun isCompatibleWith(other: CoderSemVer): Boolean {
         // in the initial development phase minor changes when there are API incompatibilities
         if (this.major == 0L) {
diff --git a/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt b/src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
@@ -325,9 +325,7 @@ class CoderWorkspacesStepView(val enableNextButtonCallback: (Boolean) -> Unit) :
                 }
             } else {
                 val coderVersion = CoderSemVer.parse(coderClient.buildVersion)
-                val testedCoderVersion = CoderSupportedVersions.maxCompatibleCoderVersion
-
-                if (!testedCoderVersion.isCompatibleWith(coderVersion)) {
+                if (!coderVersion.isInClosedRange(CoderSupportedVersions.minCompatibleCoderVersion, CoderSupportedVersions.maxCompatibleCoderVersion)) {
                     notificationBanner.apply {
                         component.isVisible = true
                         showWarning(CoderGatewayBundle.message("gateway.connector.view.coder.workspaces.unsupported.coder.version", coderClient.buildVersion))
diff --git a/src/main/resources/version/CoderSupportedVersions.properties b/src/main/resources/version/CoderSupportedVersions.properties
@@ -1 +1,2 @@
+minCompatibleCoderVersion=0.12.9
 maxCompatibleCoderVersion=0.13.1

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ class CoderSemVer(private val major: Long = 0, private val minor: Long = 0, priv`
`9`	`9`	`require(patch >= 0) { "Coder minor version must be a positive number" }`
`10`	`10`	`}`
`11`	`11`
	`12`	`+ fun isInClosedRange(start: CoderSemVer, endInclusive: CoderSemVer) = this in start..endInclusive`
`12`	`13`	`fun isCompatibleWith(other: CoderSemVer): Boolean {`
`13`	`14`	`// in the initial development phase minor changes when there are API incompatibilities`
`14`	`15`	`if (this.major == 0L) {`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+minCompatibleCoderVersion=0.12.9`
`1`	`2`	`maxCompatibleCoderVersion=0.13.1`