Remove redundant nullable return type

fioan89 · fioan89 · commit e0fab54142de · 2022-06-21T22:48:17.000+03:00
diff --git a/src/main/kotlin/com/coder/gateway/CoderGatewayMainView.kt b/src/main/kotlin/com/coder/gateway/CoderGatewayMainView.kt
@@ -25,15 +25,15 @@ class CoderGatewayMainView : GatewayConnector {
         return CoderGatewayBundle.message("gateway.connector.action.text")
     }
 
-    override fun getDescription(): String? {
+    override fun getDescription(): String {
         return CoderGatewayBundle.message("gateway.connector.description")
     }
 
-    override fun getDocumentationLink(): ActionLink? {
+    override fun getDocumentationLink(): ActionLink {
         return BrowserLink(null, "Learn more about Coder Workspaces", null, "https://coder.com/docs/coder/latest/workspaces")
     }
 
-    override fun getRecentConnections(setContentCallback: (Component) -> Unit): GatewayRecentConnections? {
+    override fun getRecentConnections(setContentCallback: (Component) -> Unit): GatewayRecentConnections {
         return CoderGatewayRecentWorkspaceConnectionsView()
     }
 
diff --git a/src/main/kotlin/com/coder/gateway/sdk/CoderRestClientService.kt b/src/main/kotlin/com/coder/gateway/sdk/CoderRestClientService.kt
@@ -33,7 +33,7 @@ class CoderRestClientService {
      * This must be called before anything else. It will authenticate with coder and retrieve a session token
      * @throws [AuthenticationException] if authentication failed
      */
-    fun initClientSession(url: URL, token: String): User? {
+    fun initClientSession(url: URL, token: String): User {
         val cookieUrl = url.toHttpUrlOrNull()!!
         val cookieJar = JavaNetCookieJar(CookieManager()).apply {
             saveFromResponse(
diff --git a/src/main/kotlin/com/coder/gateway/sdk/convertors/InstantConverter.kt b/src/main/kotlin/com/coder/gateway/sdk/convertors/InstantConverter.kt
@@ -32,7 +32,7 @@ class InstantConverter : JsonSerializer<Instant?>, JsonDeserializer<Instant?> {
      * @param typeOfSrc the actual type (fully genericized version) of the source object.
      * @return a JsonElement corresponding to the specified object.
      */
-    override fun serialize(src: Instant?, typeOfSrc: Type?, context: JsonSerializationContext?): JsonElement? {
+    override fun serialize(src: Instant?, typeOfSrc: Type?, context: JsonSerializationContext?): JsonElement {
         return JsonPrimitive(FORMATTER.format(src))
     }
 

Original file line number	Diff line number	Diff line change
`@@ -25,15 +25,15 @@ class CoderGatewayMainView : GatewayConnector {`
`25`	`25`	`return CoderGatewayBundle.message("gateway.connector.action.text")`
`26`	`26`	`}`
`27`	`27`
`28`		`- override fun getDescription(): String? {`
	`28`	`+ override fun getDescription(): String {`
`29`	`29`	`return CoderGatewayBundle.message("gateway.connector.description")`
`30`	`30`	`}`
`31`	`31`
`32`		`- override fun getDocumentationLink(): ActionLink? {`
	`32`	`+ override fun getDocumentationLink(): ActionLink {`
`33`	`33`	`return BrowserLink(null, "Learn more about Coder Workspaces", null, "https://coder.com/docs/coder/latest/workspaces")`
`34`	`34`	`}`
`35`	`35`
`36`		`- override fun getRecentConnections(setContentCallback: (Component) -> Unit): GatewayRecentConnections? {`
	`36`	`+ override fun getRecentConnections(setContentCallback: (Component) -> Unit): GatewayRecentConnections {`
`37`	`37`	`return CoderGatewayRecentWorkspaceConnectionsView()`
`38`	`38`	`}`
`39`	`39`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class InstantConverter : JsonSerializer<Instant?>, JsonDeserializer<Instant?> {`
`32`	`32`	`* @param typeOfSrc the actual type (fully genericized version) of the source object.`
`33`	`33`	`* @return a JsonElement corresponding to the specified object.`
`34`	`34`	`*/`
`35`		`- override fun serialize(src: Instant?, typeOfSrc: Type?, context: JsonSerializationContext?): JsonElement? {`
	`35`	`+ override fun serialize(src: Instant?, typeOfSrc: Type?, context: JsonSerializationContext?): JsonElement {`
`36`	`36`	`return JsonPrimitive(FORMATTER.format(src))`
`37`	`37`	`}`
`38`	`38`