Fix: connection handle window is left open

fioan89 · fioan89 · commit facce0a2c03d · 2022-12-09T00:29:37.000+02:00
- window is left open Jetbrains Client is closed - we don't actually need the window because we don't have to display anything. The workspaces are already started so no progress is needed, and we don't have any other telemetry data to show. - the fix just removes the connection window - resolves #105
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,22 +5,30 @@
 ## Unreleased
 
 ### Added
+
 - warning system when plugin might not be compatible with Coder REST API
 - a `Create workspace` button which links to Coder's templates page
 - workspace icons
 - quick toolbar action to open Coder Dashboard in the browser
 
 ### Changed
+
 - redesigned the information&warning banner. Messages can now include hyperlinks
 
+### Removed
+
+- connection handle window is no longer displayed
+
 ### Fixed
+
 - outdated Coder CLI binaries are cleaned up
 - workspace status color style: running workspaces are green, failed ones should be red, everything else is gray
 - typos in plugin description
 
 ## 2.1.2 - 2022-11-23
 
 ### Added
+
 - upgraded support for the latest Coder REST API
 - support for latest Gateway 2022.2.x builds
 
diff --git a/src/main/kotlin/com/coder/gateway/CoderGatewayConnectionProvider.kt b/src/main/kotlin/com/coder/gateway/CoderGatewayConnectionProvider.kt
@@ -89,16 +89,6 @@ class CoderGatewayConnectionProvider : GatewayConnectionProvider {
             }
 
             recentConnectionsService.addRecentConnection(RecentWorkspaceConnection(coderWorkspaceHostname, projectPath, localTimeFormatter.format(LocalDateTime.now()), ideProductCode, ideBuildNumber, ideDownloadLink, webTerminalLink))
-
-            return object : GatewayConnectionHandle(clientLifetime) {
-                override fun getTitle(): String {
-                    return "Connection to Coder Workspaces"
-                }
-
-                override fun hideToTrayOnStart(): Boolean {
-                    return false
-                }
-            }
         }
         return null
     }

Original file line number	Diff line number	Diff line change
`@@ -89,16 +89,6 @@ class CoderGatewayConnectionProvider : GatewayConnectionProvider {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`recentConnectionsService.addRecentConnection(RecentWorkspaceConnection(coderWorkspaceHostname, projectPath, localTimeFormatter.format(LocalDateTime.now()), ideProductCode, ideBuildNumber, ideDownloadLink, webTerminalLink))`
`92`		`-`
`93`		`- return object : GatewayConnectionHandle(clientLifetime) {`
`94`		`- override fun getTitle(): String {`
`95`		`- return "Connection to Coder Workspaces"`
`96`		`- }`
`97`		`-`
`98`		`- override fun hideToTrayOnStart(): Boolean {`
`99`		`- return false`
`100`		`- }`
`101`		`- }`
`102`	`92`	`}`
`103`	`93`	`return null`
`104`	`94`	`}`