Skip to content

Add extra help for certificate errors #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add extra help for certificate errors #279

merged 1 commit into from
Aug 3, 2023

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Aug 2, 2023

Since this help text contains markup which does not work in the table I added a new comment field underneath the URL input to place the error along with the help instead of trying to put it directly in the table. I moved the other errors there too to be consistent and in the table it will tell you to look up for the details.

I also swapped code-oss for v2 in two existing URLs since it seems that is the correct slug now.

badssl

Closes #251.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Qodana Community for JVM

55 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 32
Incorrect string capitalization 🔶 Warning 9
Unstable API Usage 🔶 Warning 8
Call to 'equals()' or 'hashCode()' on 'URL' object 🔶 Warning 2
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 1
Constant conditions 🔶 Warning 1
Useless call on not-null type 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@code-asher code-asher requested a review from johnstcn August 2, 2023 21:39
@code-asher code-asher merged commit a727aa8 into main Aug 3, 2023
@code-asher code-asher deleted the asher/cert-help branch August 3, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX around certificate errors
2 participants