Adding Header Commands To The Download CLI phase #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
Nov 2, 2023
Co-authored-by: Spike Curtis <spike@spikecurtis.com>
mafredri
reviewed
Nov 2, 2023
code-asher
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
The login phase of the JetBrains Coder plugin involves downloading a fresh CLI binary from the control plane. However, if the control plane is located behind a VPN or protected by Cloudflare, it requires passing relevant tokens to the download request to ensure a successful download. To handle this, JetBrains Coder introduces the concept of "header commands" as a means of adding these tokens.
Changes Made:
This pull request addresses the need to support header commands by utilizing them when downloading the CLI binary
What's Included:
Why This Matters:
Enabling header commands support for CLI binary downloads is crucial for ensuring the seamless operation of the JetBrains Coder plugin in environments where the control plane is protected by VPN or Cloudflare. This enhancement will improve the reliability and functionality of the plugin in such scenarios.
How to Verify:
Thank you for your time and consideration! 🙌