fix(kasmVNC): fix debian installation and improve logging (#326)

djarbz · web-flow · commit 7992d9d2652b · 2024-10-21T08:04:59.000+05:00
diff --git a/kasmvnc/README.md b/kasmvnc/README.md
@@ -14,7 +14,7 @@ Automatically install [KasmVNC](https://kasmweb.com/kasmvnc) in a workspace, and
 ```tf
 module "kasmvnc" {
   source              = "registry.coder.com/modules/kasmvnc/coder"
-  version             = "1.0.21"
+  version             = "1.0.22"
   agent_id            = coder_agent.example.id
   desktop_environment = "xfce"
 }
diff --git a/kasmvnc/run.sh b/kasmvnc/run.sh
@@ -19,7 +19,7 @@ download_file() {
   if command -v wget &> /dev/null; then
     wget $url -O $output
   elif command -v curl &> /dev/null; then
-    curl -L $url -o $output
+    curl -fsSL $url -o $output
   elif command -v busybox &> /dev/null; then
     busybox wget -O $output $url
   else
@@ -32,7 +32,8 @@ download_file() {
 install_deb() {
   local url=$1
   download_file $url /tmp/kasmvncserver.deb
-  sudo apt-get install --yes --no-install-recommends --no-install-suggests /tmp/kasmvncserver.deb
+  sudo apt-get update
+  DEBIAN_FRONTEND=noninteractive sudo apt-get install --yes -qq --no-install-recommends --no-install-suggests /tmp/kasmvncserver.deb
   sudo adduser $USER ssl-cert
   rm /tmp/kasmvncserver.deb
 }
@@ -103,6 +104,7 @@ fi
 
 # Check if vncserver is installed, and install if not
 if ! check_installed; then
+  echo "Installing KASM version: ${VERSION}"
   case $distro in
     ubuntu | debian | kali)
       case $version in

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ Automatically install [KasmVNC](https://kasmweb.com/kasmvnc) in a workspace, and`
`14`	`14`	```tf
`15`	`15`	`module "kasmvnc" {`
`16`	`16`	`source = "registry.coder.com/modules/kasmvnc/coder"`
`17`		`- version = "1.0.21"`
	`17`	`+ version = "1.0.22"`
`18`	`18`	`agent_id = coder_agent.example.id`
`19`	`19`	`desktop_environment = "xfce"`
`20`	`20`	`}`