From a3678c9281e46d26d735e4eadee719998dccb345 Mon Sep 17 00:00:00 2001 From: noratanxz Date: Fri, 16 May 2025 12:47:44 +0100 Subject: [PATCH 01/12] fix: postgres connection string to use db name set in values --- coder-observability/templates/_helpers.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/coder-observability/templates/_helpers.tpl b/coder-observability/templates/_helpers.tpl index a182b3d..12ab859 100644 --- a/coder-observability/templates/_helpers.tpl +++ b/coder-observability/templates/_helpers.tpl @@ -64,9 +64,9 @@ Create the name of the service account to use {{/* Postgres connector string */}} {{- define "postgres-connector-string" -}} {{- if .Values.global.postgres.password -}} -postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/postgres?sslmode={{ .Values.global.postgres.sslmode }} +postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} {{- else if .Values.global.postgres.mountSecret -}} -postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/postgres?sslmode={{ .Values.global.postgres.sslmode }} +postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} {{- else -}} {{ fail "either postgres.password or postgres.mountSecret must be defined" }} {{- end -}} From c1d15d74f0791c519cbdeeedc2deb7beeee20919 Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Fri, 23 May 2025 09:19:38 +0200 Subject: [PATCH 02/12] chore: make lint Signed-off-by: Danny Kopping --- compiled/resources.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/compiled/resources.yaml b/compiled/resources.yaml index 6f4518e..dea0d3e 100644 --- a/compiled/resources.yaml +++ b/compiled/resources.yaml @@ -994,7 +994,7 @@ data: global: target: name: postgres - data_source_name: 'postgresql://coder@localhost:5432/postgres?sslmode=disable' + data_source_name: 'postgresql://coder@localhost:5432/coder?sslmode=disable' collectors: - notify collectors: @@ -12215,7 +12215,7 @@ spec: name: exporter env: - name: DATA_SOURCE_NAME - value: 'postgresql://coder@localhost:5432/postgres?sslmode=disable' + value: 'postgresql://coder@localhost:5432/coder?sslmode=disable' envFrom: - secretRef: name: secret-postgres @@ -12270,7 +12270,7 @@ spec: metadata: annotations: prometheus.io/scrape: 'true' - checksum/config: e12c0044ef2cab3438ffdc8f5e16c24c5acf5ee36dcc8bee77294f27e53ce4a2 + checksum/config: 71bb9e7579b6e138ae28c623aa29d72025be00387da6c1b8dd5aa168c96ca1e0 labels: app: sql-exporter app.kubernetes.io/name: "database-stats" From ce59115577b2678818a7c04a4bf07b50657f584b Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Mon, 26 May 2025 13:53:38 +0200 Subject: [PATCH 03/12] chore: upgrade grafana to latest patch (v10.4.19) Signed-off-by: Danny Kopping --- coder-observability/values.yaml | 2 ++ compiled/resources.yaml | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/coder-observability/values.yaml b/coder-observability/values.yaml index f35e12b..653b829 100644 --- a/coder-observability/values.yaml +++ b/coder-observability/values.yaml @@ -275,6 +275,8 @@ grafana-agent: grafana: enabled: true + image: + tag: 10.4.19 fullnameOverride: grafana useStatefulSet: true replicas: 1 diff --git a/compiled/resources.yaml b/compiled/resources.yaml index dea0d3e..aff5679 100644 --- a/compiled/resources.yaml +++ b/compiled/resources.yaml @@ -11247,8 +11247,8 @@ spec: app.kubernetes.io/name: grafana app.kubernetes.io/instance: coder-observability annotations: - checksum/config: 4b5f6512e962f90e1dcdfbecb3713a10f3a998745141a4fc1adfcbb4cff23282 - checksum/dashboards-json-config: 3f59a9bfe9e7e9b7e6ca4ea81afd7bac7a8d78eadb7edbb44be4a327efd1d931 + checksum/config: 2828a490315379b00f2116ebe6a20dd3ca9a4d5ce5839f037c1eb0a4501ecb18 + checksum/dashboards-json-config: 010b57348b6dd1f09007330c03d22a0570022534712646511cad39a9e3cb4bb7 checksum/sc-dashboard-provider-config: 01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b kubectl.kubernetes.io/default-container: grafana spec: From 9f7fb99470f0915ddcfdf1b965aa47c5453a862c Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Mon, 26 May 2025 14:40:06 +0200 Subject: [PATCH 04/12] chore: make lint Signed-off-by: Danny Kopping --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 616428a..ba5fde2 100644 --- a/README.md +++ b/README.md @@ -381,6 +381,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main | grafana.extraConfigmapMounts[5].name | string | `"dashboards-prebuilds"` | | | grafana.extraConfigmapMounts[5].readOnly | bool | `false` | | | grafana.fullnameOverride | string | `"grafana"` | | +| grafana.image.tag | string | `"10.4.19"` | | | grafana.persistence.enabled | bool | `true` | | | grafana.persistence.size | string | `"10Gi"` | | | grafana.replicas | int | `1` | | From ee6d508d4354eed5ed3806e1c3211fdbb3fb3972 Mon Sep 17 00:00:00 2001 From: noratanxz Date: Wed, 4 Jun 2025 10:49:04 +0100 Subject: [PATCH 05/12] feat: SSL connectivity support --- coder-observability/templates/_helpers.tpl | 8 ++++++-- .../templates/statefulset-postgres-exporter.yaml | 8 +++++++- coder-observability/values.yaml | 13 +++++++++++++ 3 files changed, 26 insertions(+), 3 deletions(-) diff --git a/coder-observability/templates/_helpers.tpl b/coder-observability/templates/_helpers.tpl index 12ab859..f4b455e 100644 --- a/coder-observability/templates/_helpers.tpl +++ b/coder-observability/templates/_helpers.tpl @@ -63,10 +63,14 @@ Create the name of the service account to use {{/* Postgres connector string */}} {{- define "postgres-connector-string" -}} -{{- if .Values.global.postgres.password -}} +{{- if and .Values.global.postgres.password (eq .Values.global.postgres.sslmode "disable") -}} postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} -{{- else if .Values.global.postgres.mountSecret -}} +{{- else if and .Values.global.postgres.password (ne .Values.global.postgres.sslmode "disable") -}} +postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }}&sslrootcert={{ .Values.global.postgres.sslrootcert }} +{{- else if and .Values.global.postgres.mountSecret (eq .Values.global.postgres.sslmode "disable") -}} postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} +{{- else if and .Values.global.postgres.mountSecret (ne .Values.global.postgres.sslmode "disable") -}} +postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }}&sslrootcert={{ .Values.global.postgres.sslrootcert }} {{- else -}} {{ fail "either postgres.password or postgres.mountSecret must be defined" }} {{- end -}} diff --git a/coder-observability/templates/statefulset-postgres-exporter.yaml b/coder-observability/templates/statefulset-postgres-exporter.yaml index 229c650..4f33f25 100644 --- a/coder-observability/templates/statefulset-postgres-exporter.yaml +++ b/coder-observability/templates/statefulset-postgres-exporter.yaml @@ -29,4 +29,10 @@ spec: env: - name: DATA_SOURCE_NAME value: '{{ include "postgres-connector-string" . }}' - {{ include "postgres-secret-mount" . | nindent 10 }} \ No newline at end of file + {{ include "postgres-secret-mount" . | nindent 10 }} + + volumeMounts: + {{ toYaml .Values.global.postgres.volumeMounts | nindent 12 }} + + volumes: + {{ toYaml .Values.global.postgres.volumes | nindent 8 }} \ No newline at end of file diff --git a/coder-observability/values.yaml b/coder-observability/values.yaml index 653b829..42ac2bc 100644 --- a/coder-observability/values.yaml +++ b/coder-observability/values.yaml @@ -123,11 +123,24 @@ global: password: database: coder sslmode: disable + # add root cert path if using SSL + # sslrootcert: /home/coder/.postgresql/rootcert.pem + # ensure that your secret has a field named `PGPASSWORD` mountSecret: "secret-postgres" exporter: image: "quay.io/prometheuscommunity/postgres-exporter" + volumes: + - name: "pg-certs-mount" + configMap: + name: "pg-certs-mount-config-map" + + volumeMounts: + - name: "pg-certs-mount" + mountPath: "/home/coder/.postgresql" + readOnly: true + # global.postgres.alerts -- alerts for postgres alerts: groups: From 965a534fe76cbd12d758925b31481adc30cf1bb3 Mon Sep 17 00:00:00 2001 From: noratanxz Date: Wed, 4 Jun 2025 10:55:32 +0100 Subject: [PATCH 06/12] chore: make lint --- compiled/resources.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/compiled/resources.yaml b/compiled/resources.yaml index aff5679..503f485 100644 --- a/compiled/resources.yaml +++ b/compiled/resources.yaml @@ -12219,6 +12219,14 @@ spec: envFrom: - secretRef: name: secret-postgres + volumeMounts: + - mountPath: /home/coder/.postgresql + name: pg-certs-mount + readOnly: true + volumes: + - configMap: + name: pg-certs-mount-config-map + name: pg-certs-mount --- # Source: coder-observability/templates/statefulset-runbook-viewer.yaml apiVersion: apps/v1 From b4f803634c02dfeab013add82ff76d32a30a838e Mon Sep 17 00:00:00 2001 From: noratanxz Date: Wed, 4 Jun 2025 10:59:13 +0100 Subject: [PATCH 07/12] chore: uncomment value --- coder-observability/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coder-observability/values.yaml b/coder-observability/values.yaml index 42ac2bc..c4277d7 100644 --- a/coder-observability/values.yaml +++ b/coder-observability/values.yaml @@ -124,7 +124,7 @@ global: database: coder sslmode: disable # add root cert path if using SSL - # sslrootcert: /home/coder/.postgresql/rootcert.pem + sslrootcert: /home/coder/.postgresql/rootcert.pem # ensure that your secret has a field named `PGPASSWORD` mountSecret: "secret-postgres" From 91e58e22889020db99268a8c2643fe5a415e7cd2 Mon Sep 17 00:00:00 2001 From: Eric Date: Wed, 4 Jun 2025 11:29:36 +0000 Subject: [PATCH 08/12] update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ba5fde2..1edc211 100644 --- a/README.md +++ b/README.md @@ -258,7 +258,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main | global.dashboards.timerange | string | `"12h"` | how far back dashboards should look | | global.externalScheme | string | `"http"` | | | global.externalZone | string | `"svc.cluster.local"` | | -| global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","exporter":{"image":"quay.io/prometheuscommunity/postgres-exporter"},"hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","username":"coder"}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts | +| global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","exporter":{"image":"quay.io/prometheuscommunity/postgres-exporter"},"hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","sslrootcert":"/home/coder/.postgresql/rootcert.pem","username":"coder","volumeMounts":[{"mountPath":"/home/coder/.postgresql","name":"pg-certs-mount","readOnly":true}],"volumes":[{"configMap":{"name":"pg-certs-mount-config-map"},"name":"pg-certs-mount"}]}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts | | global.postgres.alerts | object | `{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}}` | alerts for postgres | | global.telemetry | object | `{"metrics":{"scrape_interval":"15s","scrape_timeout":"12s"}}` | control telemetry collection | | global.telemetry.metrics | object | `{"scrape_interval":"15s","scrape_timeout":"12s"}` | control metric collection | From 847beb3af40ac92f4a501f4d1a46a28e4b36404f Mon Sep 17 00:00:00 2001 From: Danny Kopping Date: Thu, 5 Jun 2025 09:28:44 +0200 Subject: [PATCH 09/12] Add CODEOWNERS Signed-off-by: Danny Kopping --- CODEOWNERS | 1 + 1 file changed, 1 insertion(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000..4521512 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1 @@ +* @dannykopping \ No newline at end of file From 6db14cffa7248050469002721825e3ba903669c1 Mon Sep 17 00:00:00 2001 From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com> Date: Thu, 5 Jun 2025 19:11:37 +0000 Subject: [PATCH 10/12] feat: make postgres SSL certificate paths configurable - Remove hardcoded /home/coder/.postgresql paths - Make sslrootcert, volumes, and volumeMounts configurable with no defaults - Add conditional rendering to avoid empty volume mounts - Update postgres connector string to handle optional sslrootcert - Update README documentation Fixes hardcoded certificate paths introduced in PR #40 --- README.md | 2 +- coder-observability/templates/_helpers.tpl | 8 ++++++ .../statefulset-postgres-exporter.yaml | 8 +++--- coder-observability/values.yaml | 27 +++++++++++-------- 4 files changed, 30 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index 1edc211..1a80c26 100644 --- a/README.md +++ b/README.md @@ -258,7 +258,7 @@ values which are defined [here](https://github.com/grafana/helm-charts/tree/main | global.dashboards.timerange | string | `"12h"` | how far back dashboards should look | | global.externalScheme | string | `"http"` | | | global.externalZone | string | `"svc.cluster.local"` | | -| global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","exporter":{"image":"quay.io/prometheuscommunity/postgres-exporter"},"hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","sslrootcert":"/home/coder/.postgresql/rootcert.pem","username":"coder","volumeMounts":[{"mountPath":"/home/coder/.postgresql","name":"pg-certs-mount","readOnly":true}],"volumes":[{"configMap":{"name":"pg-certs-mount-config-map"},"name":"pg-certs-mount"}]}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts | +| global.postgres | object | `{"alerts":{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}},"database":"coder","exporter":{"image":"quay.io/prometheuscommunity/postgres-exporter"},"hostname":"localhost","mountSecret":"secret-postgres","password":null,"port":5432,"sslmode":"disable","sslrootcert":null,"username":"coder","volumeMounts":[],"volumes":[]}` | postgres connection information NOTE: these settings are global so we can parameterise some values which get rendered by subcharts | | global.postgres.alerts | object | `{"groups":{"Basic":{"delay":"1m","enabled":true},"Connections":{"delay":"5m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}},"Notifications":{"delay":"15m","enabled":true,"thresholds":{"critical":0.9,"notify":0.5,"warning":0.8}}}}` | alerts for postgres | | global.telemetry | object | `{"metrics":{"scrape_interval":"15s","scrape_timeout":"12s"}}` | control telemetry collection | | global.telemetry.metrics | object | `{"scrape_interval":"15s","scrape_timeout":"12s"}` | control metric collection | diff --git a/coder-observability/templates/_helpers.tpl b/coder-observability/templates/_helpers.tpl index f4b455e..0d8578d 100644 --- a/coder-observability/templates/_helpers.tpl +++ b/coder-observability/templates/_helpers.tpl @@ -66,12 +66,20 @@ Create the name of the service account to use {{- if and .Values.global.postgres.password (eq .Values.global.postgres.sslmode "disable") -}} postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} {{- else if and .Values.global.postgres.password (ne .Values.global.postgres.sslmode "disable") -}} +{{- if .Values.global.postgres.sslrootcert -}} postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }}&sslrootcert={{ .Values.global.postgres.sslrootcert }} +{{- else -}} +postgresql://{{ .Values.global.postgres.username }}:{{ urlquery .Values.global.postgres.password }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} +{{- end -}} {{- else if and .Values.global.postgres.mountSecret (eq .Values.global.postgres.sslmode "disable") -}} postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} {{- else if and .Values.global.postgres.mountSecret (ne .Values.global.postgres.sslmode "disable") -}} +{{- if .Values.global.postgres.sslrootcert -}} postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }}&sslrootcert={{ .Values.global.postgres.sslrootcert }} {{- else -}} +postgresql://{{ .Values.global.postgres.username }}@{{ .Values.global.postgres.hostname }}:{{ .Values.global.postgres.port }}/{{ .Values.global.postgres.database }}?sslmode={{ .Values.global.postgres.sslmode }} +{{- end -}} +{{- else -}} {{ fail "either postgres.password or postgres.mountSecret must be defined" }} {{- end -}} {{- end }} diff --git a/coder-observability/templates/statefulset-postgres-exporter.yaml b/coder-observability/templates/statefulset-postgres-exporter.yaml index 4f33f25..a1f6e55 100644 --- a/coder-observability/templates/statefulset-postgres-exporter.yaml +++ b/coder-observability/templates/statefulset-postgres-exporter.yaml @@ -30,9 +30,11 @@ spec: - name: DATA_SOURCE_NAME value: '{{ include "postgres-connector-string" . }}' {{ include "postgres-secret-mount" . | nindent 10 }} - + {{- if .Values.global.postgres.volumeMounts }} volumeMounts: {{ toYaml .Values.global.postgres.volumeMounts | nindent 12 }} - + {{- end }} + {{- if .Values.global.postgres.volumes }} volumes: - {{ toYaml .Values.global.postgres.volumes | nindent 8 }} \ No newline at end of file + {{ toYaml .Values.global.postgres.volumes | nindent 8 }} + {{- end }} \ No newline at end of file diff --git a/coder-observability/values.yaml b/coder-observability/values.yaml index c4277d7..0413cce 100644 --- a/coder-observability/values.yaml +++ b/coder-observability/values.yaml @@ -123,23 +123,28 @@ global: password: database: coder sslmode: disable - # add root cert path if using SSL - sslrootcert: /home/coder/.postgresql/rootcert.pem + # SSL root certificate path - only required when sslmode != "disable" + # Example: /path/to/certs/rootcert.pem + sslrootcert: # ensure that your secret has a field named `PGPASSWORD` mountSecret: "secret-postgres" exporter: image: "quay.io/prometheuscommunity/postgres-exporter" - volumes: - - name: "pg-certs-mount" - configMap: - name: "pg-certs-mount-config-map" - - volumeMounts: - - name: "pg-certs-mount" - mountPath: "/home/coder/.postgresql" - readOnly: true + # volumes and volumeMounts for SSL certificates + # Only required when using SSL connections (sslmode != "disable") + # Example configuration: + # volumes: + # - name: "pg-certs-mount" + # configMap: + # name: "pg-certs-mount-config-map" + # volumeMounts: + # - name: "pg-certs-mount" + # mountPath: "/path/to/certs" + # readOnly: true + volumes: [] + volumeMounts: [] # global.postgres.alerts -- alerts for postgres alerts: From 6e8c46d38973c550bc4286165cf7a70e707313df Mon Sep 17 00:00:00 2001 From: "blink-so[bot]" <211532188+blink-so[bot]@users.noreply.github.com> Date: Thu, 5 Jun 2025 19:15:05 +0000 Subject: [PATCH 11/12] refactor: make comments more brief in values.yaml - Remove example configuration comments - Keep only essential comments for SSL certificate configuration --- coder-observability/values.yaml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/coder-observability/values.yaml b/coder-observability/values.yaml index 0413cce..6d06981 100644 --- a/coder-observability/values.yaml +++ b/coder-observability/values.yaml @@ -124,7 +124,6 @@ global: database: coder sslmode: disable # SSL root certificate path - only required when sslmode != "disable" - # Example: /path/to/certs/rootcert.pem sslrootcert: # ensure that your secret has a field named `PGPASSWORD` @@ -133,16 +132,6 @@ global: image: "quay.io/prometheuscommunity/postgres-exporter" # volumes and volumeMounts for SSL certificates - # Only required when using SSL connections (sslmode != "disable") - # Example configuration: - # volumes: - # - name: "pg-certs-mount" - # configMap: - # name: "pg-certs-mount-config-map" - # volumeMounts: - # - name: "pg-certs-mount" - # mountPath: "/path/to/certs" - # readOnly: true volumes: [] volumeMounts: [] From 3560b220cdb8362a4033bd83830018dc227e0bb5 Mon Sep 17 00:00:00 2001 From: Eric Date: Thu, 5 Jun 2025 19:49:59 +0000 Subject: [PATCH 12/12] update compiled resources.yaml --- compiled/resources.yaml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/compiled/resources.yaml b/compiled/resources.yaml index 503f485..aff5679 100644 --- a/compiled/resources.yaml +++ b/compiled/resources.yaml @@ -12219,14 +12219,6 @@ spec: envFrom: - secretRef: name: secret-postgres - volumeMounts: - - mountPath: /home/coder/.postgresql - name: pg-certs-mount - readOnly: true - volumes: - - configMap: - name: pg-certs-mount-config-map - name: pg-certs-mount --- # Source: coder-observability/templates/statefulset-runbook-viewer.yaml apiVersion: apps/v1