-
Notifications
You must be signed in to change notification settings - Fork 3
Dotfiles fails: /bin/sh: 2: Bad substitution #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @jaulz, this module uses |
@matifali thanks for the feedback! In fact, I checked the documentation but it sounded to me that the script is optional is and if it doesn't exist the configuration files are copied only. |
@jaulz can you manually run |
@matifali it's also not really working: Maybe because there is already other stuff in the folder (e.g. code-server from other module)? |
The issue is with |
@matifali to me this looks problematic: https://github.com/coder/modules/blob/f8faea1855fb5fbb4db99d34421b5d6999b17ca3/dotfiles/main.tf#L31 We should make sure this check is Perhaps that check is better done in terraform? Or perhaps the trim spaces and then just check for emptyness in the script. Or not create the script if empty. |
The dotfiles modules fails on my side:

I added the module like this:
and specified this repository. Is there anything else I need to set up?
The text was updated successfully, but these errors were encountered: