From 0c1ab0396dc9595953641a5691cfd7de5d98d102 Mon Sep 17 00:00:00 2001 From: Sean Smith Date: Wed, 9 Jun 2021 14:31:03 -0500 Subject: [PATCH 1/2] chore: Remove IgnoreErrors check for test logger --- sloggers/slogtest/t.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/sloggers/slogtest/t.go b/sloggers/slogtest/t.go index 2c7af7b..3b056ed 100644 --- a/sloggers/slogtest/t.go +++ b/sloggers/slogtest/t.go @@ -61,9 +61,6 @@ func (ts testSink) LogEntry(ctx context.Context, ent slog.SinkEntry) { ts.tb.Error(s) } case slog.LevelFatal: - if ts.opts.IgnoreErrors { - panic("slogtest: cannot fatal in tests when IgnoreErrors option is set") - } ts.tb.Fatal(s) } } From eb61a52b4916af4bea009fa51e491221ed12d17e Mon Sep 17 00:00:00 2001 From: Sean Smith Date: Wed, 9 Jun 2021 14:35:03 -0500 Subject: [PATCH 2/2] Update test --- sloggers/slogtest/t_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sloggers/slogtest/t_test.go b/sloggers/slogtest/t_test.go index cdac6ec..efe8fa2 100644 --- a/sloggers/slogtest/t_test.go +++ b/sloggers/slogtest/t_test.go @@ -39,7 +39,7 @@ func TestIgnoreErrors(t *testing.T) { defer func() { recover() - assert.Equal(t, "fatals", 0, tb.fatals) + assert.Equal(t, "fatals", 1, tb.fatals) }() l.Fatal(bg, "hello")