Skip to content

Make stackdriver compatible with ops agent #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Make stackdriver compatible with ops agent #157

merged 2 commits into from
Nov 30, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Nov 30, 2022

Not sure if this threatens to break anything

@ammario ammario requested a review from kylecarbs November 30, 2022 03:02
@coveralls
Copy link

coveralls commented Nov 30, 2022

Pull Request Test Coverage Report for Build f347c6068d9b03924a2e7f53e8d8ebe8427b1859-PR-

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.558%

Totals Coverage Status
Change from base Build 18dce5c2cd5f311781610661c14b9f3a681bb550: 0.02%
Covered Lines: 719
Relevant Lines: 737

💛 - Coveralls

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me if you tested it.

// "my_field": "field value"
// }
// }
// {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gofmt change has been driving us crazy at @terrastruct

We refuse to use go 1.19 for now because of it. Ruined all our ascii diagrams lol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I was quite confused by this.

@ammario
Copy link
Member Author

ammario commented Nov 30, 2022

@nhooyr — thank you for your blessing

@ammario ammario merged commit 7c313ab into main Nov 30, 2022
@ammario ammario deleted the fix-stackdriver branch November 30, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants