From 5b243938b53bf1a66144fb48bb845abbdedac686 Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Tue, 16 Mar 2021 12:17:55 -0500 Subject: [PATCH 1/3] feat: add assert.False --- sloggers/slogtest/assert/assert.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sloggers/slogtest/assert/assert.go b/sloggers/slogtest/assert/assert.go index e246a2f..f397303 100644 --- a/sloggers/slogtest/assert/assert.go +++ b/sloggers/slogtest/assert/assert.go @@ -50,6 +50,12 @@ func True(t testing.TB, name string, act bool) { Equal(t, name, true, act) } +// False asserts act == true. +func False(t testing.TB, name string, act bool) { + slog.Helper() + Equal(t, name, false, act) +} + // Error asserts err != nil. func Error(t testing.TB, name string, err error) { slog.Helper() From 7f2ae8cdb1c00e060530e474e725f2dec9247034 Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Tue, 16 Mar 2021 12:21:34 -0500 Subject: [PATCH 2/3] fixup! feat: add assert.False --- sloggers/slogtest/assert/assert.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sloggers/slogtest/assert/assert.go b/sloggers/slogtest/assert/assert.go index f397303..e11476f 100644 --- a/sloggers/slogtest/assert/assert.go +++ b/sloggers/slogtest/assert/assert.go @@ -50,7 +50,7 @@ func True(t testing.TB, name string, act bool) { Equal(t, name, true, act) } -// False asserts act == true. +// False asserts act == false. func False(t testing.TB, name string, act bool) { slog.Helper() Equal(t, name, false, act) From 84b0c764850acb2773a726f4943fb5d861d034ed Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Tue, 16 Mar 2021 12:24:53 -0500 Subject: [PATCH 3/3] add test --- sloggers/slogtest/assert/assert_test.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/sloggers/slogtest/assert/assert_test.go b/sloggers/slogtest/assert/assert_test.go index 82d9a5d..49f6c02 100644 --- a/sloggers/slogtest/assert/assert_test.go +++ b/sloggers/slogtest/assert/assert_test.go @@ -75,6 +75,19 @@ func TestTrue(t *testing.T) { assert.True(tb, "meow", false) } +func TestFalse(t *testing.T) { + t.Parallel() + + tb := &fakeTB{} + assert.False(tb, "woof", false) + + defer func() { + recover() + simpleassert.Equal(t, "fatals", 1, tb.fatals) + }() + assert.False(tb, "woof", true) +} + func TestError(t *testing.T) { t.Parallel()