net/connstats: always stat even if no activity occurred (#9)

kylecarbs · web-flow · commit 059dea1029a4 · 2023-03-06T19:46:08.000-06:00
It should be on the responsibility of the caller to send stats or not if
no activity occurred. This was making it difficult to periodically send
stats because we'd need multiple tickers that would have to align.
diff --git a/net/connstats/stats.go b/net/connstats/stats.go
@@ -67,7 +67,7 @@ func NewStatistics(maxPeriod time.Duration, maxConns int, dump func(start, end t
 			case <-s.shutdownCtx.Done():
 				cc = s.extract()
 			}
-			if len(cc.virtual)+len(cc.physical) > 0 && dump != nil {
+			if dump != nil {
 				dump(cc.start, cc.end, cc.virtual, cc.physical)
 			}
 			if s.shutdownCtx.Err() != nil {

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ func NewStatistics(maxPeriod time.Duration, maxConns int, dump func(start, end t`
`67`	`67`	`case <-s.shutdownCtx.Done():`
`68`	`68`	`cc = s.extract()`
`69`	`69`	`}`
`70`		`- if len(cc.virtual)+len(cc.physical) > 0 && dump != nil {`
	`70`	`+ if dump != nil {`
`71`	`71`	`dump(cc.start, cc.end, cc.virtual, cc.physical)`
`72`	`72`	`}`
`73`	`73`	`if s.shutdownCtx.Err() != nil {`