wgengine/netstack: close ipstack when netstack.Impl is closed

kylecarbs · kylecarbs · commit 0acf62f4b4d0 · 2022-06-28T17:29:05.000Z
Fixes netstack.Impl leaking goroutines after shutdown.

Signed-off-by: kylecarbs &lt;kyle@carberry.com&gt;
diff --git a/wgengine/netstack/netstack.go b/wgengine/netstack/netstack.go
@@ -201,6 +201,7 @@ func Create(logf logger.Logf, tundev *tstun.Wrapper, e wgengine.Engine, mc *magi
 
 func (ns *Impl) Close() error {
 	ns.ctxCancel()
+	ns.ipstack.Close()
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ func Create(logf logger.Logf, tundev tstun.Wrapper, e wgengine.Engine, mc magi`
`201`	`201`
`202`	`202`	`func (ns *Impl) Close() error {`
`203`	`203`	`ns.ctxCancel()`
	`204`	`+ ns.ipstack.Close()`
`204`	`205`	`return nil`
`205`	`206`	`}`
`206`	`207`