Merge pull request #26 from coder/disable-sack

mtojek · web-flow · commit 0f235cf3f2ea · 2023-05-22T13:44:34.000+02:00
wgengine/netstack: disable TCP SACK
diff --git a/wgengine/netstack/netstack.go b/wgengine/netstack/netstack.go
@@ -174,16 +174,13 @@ func Create(logf logger.Logf, tundev *tstun.Wrapper, e wgengine.Engine, mc *magi
 		NetworkProtocols:   []stack.NetworkProtocolFactory{ipv4.NewProtocol, ipv6.NewProtocol},
 		TransportProtocols: []stack.TransportProtocolFactory{tcp.NewProtocol, udp.NewProtocol, icmp.NewProtocol4, icmp.NewProtocol6},
 	})
-	sackEnabledOpt := tcpip.TCPSACKEnabled(true) // TCP SACK is disabled by default
+	// Issue: https://github.com/coder/coder/issues/7388
+	//
+	/*sackEnabledOpt := tcpip.TCPSACKEnabled(true) // TCP SACK is disabled by default
 	tcpipErr := ipstack.SetTransportProtocolOption(tcp.ProtocolNumber, &sackEnabledOpt)
 	if tcpipErr != nil {
 		return nil, fmt.Errorf("could not enable TCP SACK: %v", tcpipErr)
-	}
-	congestionOpt := tcpip.CongestionControlOption("cubic") // Reno is used by default
-	tcpipErr = ipstack.SetTransportProtocolOption(tcp.ProtocolNumber, &congestionOpt)
-	if tcpipErr != nil {
-		return nil, fmt.Errorf("could not set TCP congestion control: %v", tcpipErr)
-	}
+	}*/
 	linkEP := &protectedLinkEndpoint{Endpoint: channel.New(512, tstun.DefaultMTU(), "")}
 	if tcpipProblem := ipstack.CreateNIC(nicID, linkEP); tcpipProblem != nil {
 		return nil, fmt.Errorf("could not create netstack NIC: %v", tcpipProblem)
