net/dns: [win] fix regression in disableDynamicUpdate

Maisem Ali · maisem · commit 68d9d161f4da · 2022-08-29T15:28:59.000-07:00
Somehow I accidentally set the wrong registry value here. It should be DisableDynamicUpdate=1 and not EnableDNSUpdate=0. This is a regression from 545639e. Signed-off-by: Maisem Ali <maisem@tailscale.com>
diff --git a/net/dns/manager_windows.go b/net/dns/manager_windows.go
@@ -388,10 +388,10 @@ func (m windowsManager) Close() error {
 // Windows DHCP client from sending dynamic DNS updates for our interface to
 // AD domain controllers.
 func (m windowsManager) disableDynamicUpdates() error {
-	if err := m.setSingleDWORD(winutil.IPv4TCPIPInterfacePrefix, "EnableDNSUpdate", 0); err != nil {
+	if err := m.setSingleDWORD(winutil.IPv4TCPIPInterfacePrefix, "DisableDynamicUpdate", 1); err != nil {
 		return err
 	}
-	if err := m.setSingleDWORD(winutil.IPv6TCPIPInterfacePrefix, "EnableDNSUpdate", 0); err != nil {
+	if err := m.setSingleDWORD(winutil.IPv6TCPIPInterfacePrefix, "DisableDynamicUpdate", 1); err != nil {
 		return err
 	}
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -388,10 +388,10 @@ func (m windowsManager) Close() error {`
`388`	`388`	`// Windows DHCP client from sending dynamic DNS updates for our interface to`
`389`	`389`	`// AD domain controllers.`
`390`	`390`	`func (m windowsManager) disableDynamicUpdates() error {`
`391`		`- if err := m.setSingleDWORD(winutil.IPv4TCPIPInterfacePrefix, "EnableDNSUpdate", 0); err != nil {`
	`391`	`+ if err := m.setSingleDWORD(winutil.IPv4TCPIPInterfacePrefix, "DisableDynamicUpdate", 1); err != nil {`
`392`	`392`	`return err`
`393`	`393`	`}`
`394`		`- if err := m.setSingleDWORD(winutil.IPv6TCPIPInterfacePrefix, "EnableDNSUpdate", 0); err != nil {`
	`394`	`+ if err := m.setSingleDWORD(winutil.IPv6TCPIPInterfacePrefix, "DisableDynamicUpdate", 1); err != nil {`
`395`	`395`	`return err`
`396`	`396`	`}`
`397`	`397`	`return nil`