Skip to content

Commit a5fd51e

Browse files
committed
net/art: disable the IPv6 100k routes benchmark.
At the current unoptimized memory utilization of the various data structures, 100k IPv6 routes consumes in the ballpark of 3-4GiB, which risks OOMing our 386 test machine. Until we have the optimizations to (drastically) reduce that consumption, skip the test that bloats too much for 32-bit machines. Signed-off-by: David Anderson <danderson@tailscale.com>
1 parent a7c910e commit a5fd51e

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

net/art/table_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,15 @@ func TestDeleteShuffled(t *testing.T) {
205205
}
206206
}
207207

208-
var benchRouteCount = []int{10, 100, 1000, 10_000, 100_000}
208+
// 100k routes for IPv6, at the current size of strideTable and strideEntry, is
209+
// in the ballpark of 4GiB if you assume worst-case prefix distribution. Future
210+
// optimizations will knock down the memory consumption by over an order of
211+
// magnitude, so for now just skip the 100k benchmarks to stay well away of
212+
// OOMs.
213+
//
214+
// TODO(go/bug/7781): reenable larger table tests once memory utilization is
215+
// optimized.
216+
var benchRouteCount = []int{10, 100, 1000, 10_000} //, 100_000}
209217

210218
// forFamilyAndCount runs the benchmark fn with different sets of
211219
// routes.

0 commit comments

Comments
 (0)