wgengine/monitor: add --monitor-duration flag to opt-in TestMonitorMode

bradfitz · bradfitz · commit d5a870b4dcba · 2023-04-17T11:14:40.000-07:00
TestMonitorMode skips by default, without the --monitor flag, and then it previously ran forever. This adds an option --monitor-duration flag that defaults to zero (run forever) but if non-zero bounds how long the tests runs. This means you can then also use e.g. `go test --cpuprofile` and capture a CPU/mem profile for a minute or two. Updates tailscale#7621 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
diff --git a/wgengine/monitor/monitor_test.go b/wgengine/monitor/monitor_test.go
@@ -5,6 +5,7 @@ package monitor
 
 import (
 	"flag"
+	"sync/atomic"
 	"testing"
 	"time"
 
@@ -55,7 +56,10 @@ func TestMonitorInjectEvent(t *testing.T) {
 	}
 }
 
-var monitor = flag.String("monitor", "", `go into monitor mode like 'route monitor'; test never terminates. Value can be either "raw" or "callback"`)
+var (
+	monitor         = flag.String("monitor", "", `go into monitor mode like 'route monitor'; test never terminates. Value can be either "raw" or "callback"`)
+	monitorDuration = flag.Duration("monitor-duration", 0, "if non-zero, how long to run TestMonitorMode. Zero means forever.")
+)
 
 func TestMonitorMode(t *testing.T) {
 	switch *monitor {
@@ -71,18 +75,38 @@ func TestMonitorMode(t *testing.T) {
 	}
 	switch *monitor {
 	case "raw":
+		var closed atomic.Bool
+		if *monitorDuration != 0 {
+			t := time.AfterFunc(*monitorDuration, func() {
+				closed.Store(true)
+				mon.Close()
+			})
+			defer t.Stop()
+		}
 		for {
 			msg, err := mon.om.Receive()
+			if closed.Load() {
+				return
+			}
 			if err != nil {
 				t.Fatal(err)
 			}
 			t.Logf("msg: %#v", msg)
 		}
 	case "callback":
+		var done <-chan time.Time
+		if *monitorDuration != 0 {
+			t := time.NewTimer(*monitorDuration)
+			defer t.Stop()
+			done = t.C
+		}
+		n := 0
 		mon.RegisterChangeCallback(func(changed bool, st *interfaces.State) {
+			n++
 			t.Logf("cb: changed=%v, ifSt=%v", changed, st)
 		})
 		mon.Start()
-		select {}
+		<-done
+		t.Logf("%v callbacks", n)
 	}
 }
