ipn: rename SetRunExitNode to SetAdvertiseExitNode

bradfitz · bradfitz · commit e68d87eb442e · 2022-01-06T16:17:03.000-08:00
From Maisem's code review feedback where he mashed the merge
button by mistake.

Change-Id: I55abce036a6c25dc391250514983125dda10126c
Signed-off-by: Brad Fitzpatrick &lt;bradfitz@tailscale.com&gt;
diff --git a/ipn/prefs.go b/ipn/prefs.go
@@ -446,9 +446,9 @@ func (p *Prefs) AdvertisesExitNode() bool {
 	return v4 && v6
 }
 
-// SetRunExitNode mutates p (if non-nil) to add or remove the two
+// SetAdvertiseExitNode mutates p (if non-nil) to add or remove the two
 // /0 exit node routes.
-func (p *Prefs) SetRunExitNode(runExit bool) {
+func (p *Prefs) SetAdvertiseExitNode(runExit bool) {
 	if p == nil {
 		return
 	}
diff --git a/ipn/prefs_test.go b/ipn/prefs_test.go
@@ -659,18 +659,18 @@ func TestPrefsExitNode(t *testing.T) {
 	p.AdvertiseRoutes = []netaddr.IPPrefix{
 		netaddr.MustParseIPPrefix("10.0.0.0/16"),
 	}
-	p.SetRunExitNode(true)
+	p.SetAdvertiseExitNode(true)
 	if got, want := len(p.AdvertiseRoutes), 3; got != want {
 		t.Errorf("routes = %d; want %d", got, want)
 	}
-	p.SetRunExitNode(true)
+	p.SetAdvertiseExitNode(true)
 	if got, want := len(p.AdvertiseRoutes), 3; got != want {
 		t.Errorf("routes = %d; want %d", got, want)
 	}
 	if !p.AdvertisesExitNode() {
 		t.Errorf("not advertising after enable")
 	}
-	p.SetRunExitNode(false)
+	p.SetAdvertiseExitNode(false)
 	if p.AdvertisesExitNode() {
 		t.Errorf("advertising after disable")
 	}

Original file line number	Diff line number	Diff line change
`@@ -446,9 +446,9 @@ func (p *Prefs) AdvertisesExitNode() bool {`
`446`	`446`	`return v4 && v6`
`447`	`447`	`}`
`448`	`448`
`449`		`-// SetRunExitNode mutates p (if non-nil) to add or remove the two`
	`449`	`+// SetAdvertiseExitNode mutates p (if non-nil) to add or remove the two`
`450`	`450`	`// /0 exit node routes.`
`451`		`-func (p *Prefs) SetRunExitNode(runExit bool) {`
	`451`	`+func (p *Prefs) SetAdvertiseExitNode(runExit bool) {`
`452`	`452`	`if p == nil {`
`453`	`453`	`return`
`454`	`454`	`}`
Original file line number	Diff line number	Diff line change
`@@ -659,18 +659,18 @@ func TestPrefsExitNode(t *testing.T) {`
`659`	`659`	`p.AdvertiseRoutes = []netaddr.IPPrefix{`
`660`	`660`	`netaddr.MustParseIPPrefix("10.0.0.0/16"),`
`661`	`661`	`}`
`662`		`- p.SetRunExitNode(true)`
	`662`	`+ p.SetAdvertiseExitNode(true)`
`663`	`663`	`if got, want := len(p.AdvertiseRoutes), 3; got != want {`
`664`	`664`	`t.Errorf("routes = %d; want %d", got, want)`
`665`	`665`	`}`
`666`		`- p.SetRunExitNode(true)`
	`666`	`+ p.SetAdvertiseExitNode(true)`
`667`	`667`	`if got, want := len(p.AdvertiseRoutes), 3; got != want {`
`668`	`668`	`t.Errorf("routes = %d; want %d", got, want)`
`669`	`669`	`}`
`670`	`670`	`if !p.AdvertisesExitNode() {`
`671`	`671`	`t.Errorf("not advertising after enable")`
`672`	`672`	`}`
`673`		`- p.SetRunExitNode(false)`
	`673`	`+ p.SetAdvertiseExitNode(false)`
`674`	`674`	`if p.AdvertisesExitNode() {`
`675`	`675`	`t.Errorf("advertising after disable")`
`676`	`676`	`}`