more pr suggestions

johnstcn · johnstcn · commit 154792908aec · 2025-09-05T14:29:59.000+01:00
diff --git a/scripts/check_go_version.sh b/scripts/check_go_version.sh
@@ -1,34 +1,15 @@
 #!/usr/bin/env bash
 set -euo pipefail
 
-fix=0
-args="$(getopt -o "" -l fix -- "$@")"
-eval set -- "$args"
-while true; do
-	case "$1" in
-	--fix)
-		fix=1
-        shift
-		;;
-	--)
-		shift
-		break
-		;;
-	*)
-		error "Unrecognized option: $1"
-		;;
-	esac
-done
-
 MOD_VERSION=$(go mod edit -json | jq -r .Go)
 echo "go.mod version: $MOD_VERSION"
 STATUS=0
 
-if [[ $fix -eq 1 ]]; then
+if [[ " $* " == *" --fix "* ]]; then
     for wf in .github/workflows/*.{yml,yaml}; do
         sed -i "s/go-version:.*/go-version: \"${MOD_VERSION}\"/g" "${wf}"
     done
-    exit $STATUS
+    exit 0
 fi
 
 for wf in .github/workflows/*.{yml,yaml}; do
@@ -37,9 +18,9 @@ for wf in .github/workflows/*.{yml,yaml}; do
         continue
     fi
 
-    UNIQUE_WF_VERSIONS=$(echo "$WF_VERSIONS" | sort -u)
+    UNIQUE_WF_VERSIONS=$(sort -u <<<"$WF_VERSIONS")
     for ver in $UNIQUE_WF_VERSIONS; do
-        if [[ "${ver}" != "$MOD_VERSION" ]]; then
+        if [[ $ver != "$MOD_VERSION" ]]; then
             STATUS=1
             echo "❌ $wf: go.mod=$MOD_VERSION but workflow uses $(tr '\n' ' ' <<<"$UNIQUE_WF_VERSIONS")"
             continue
