feat: add validation for timezone

evgeniy-scherbina · evgeniy-scherbina · commit d3f00d9fbfb6 · 2025-06-10T15:15:34.000Z
diff --git a/provider/workspace_preset.go b/provider/workspace_preset.go
@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -143,6 +144,16 @@ func workspacePresetDataSource() *schema.Resource {
 									"timezone": {
 										Type:     schema.TypeString,
 										Required: true,
+										ValidateFunc: func(val interface{}, key string) ([]string, []error) {
+											timezone := val.(string)
+
+											_, err := time.LoadLocation(timezone)
+											if err != nil {
+												return nil, []error{fmt.Errorf("failed to load location: %w", err)}
+											}
+
+											return nil, nil
+										},
 									},
 									"schedule": {
 										Type:     schema.TypeList,
diff --git a/provider/workspace_preset_test.go b/provider/workspace_preset_test.go
@@ -462,6 +462,52 @@ func TestWorkspacePreset(t *testing.T) {
 			}`,
 			ExpectError: regexp.MustCompile(`failed to parse cron spec: end of range \(26\) above maximum \(23\): 25-26`),
 		},
+		{
+			Name: "Prebuilds is set with a valid autoscaling.timezone field",
+			Config: `
+			data "coder_workspace_preset" "preset_1" {
+				name = "preset_1"
+				prebuilds {
+					instances = 1
+					autoscaling {
+						timezone = "America/Los_Angeles"
+						schedule {
+							cron = "* 8-18 * * 1-5"
+							instances = 3
+						}
+					}
+				}
+			}`,
+			ExpectError: nil,
+			Check: func(state *terraform.State) error {
+				require.Len(t, state.Modules, 1)
+				require.Len(t, state.Modules[0].Resources, 1)
+				resource := state.Modules[0].Resources["data.coder_workspace_preset.preset_1"]
+				require.NotNil(t, resource)
+				attrs := resource.Primary.Attributes
+				require.Equal(t, attrs["name"], "preset_1")
+				require.Equal(t, attrs["prebuilds.0.autoscaling.0.timezone"], "America/Los_Angeles")
+				return nil
+			},
+		},
+		{
+			Name: "Prebuilds is set with an invalid autoscaling.timezone field",
+			Config: `
+			data "coder_workspace_preset" "preset_1" {
+				name = "preset_1"
+				prebuilds {
+					instances = 1
+					autoscaling {
+						timezone = "InvalidLocation"
+						schedule {
+							cron = "* 8-18 * * 1-5"
+							instances = 3
+						}
+					}
+				}
+			}`,
+			ExpectError: regexp.MustCompile(`failed to load location: unknown time zone InvalidLocation`),
+		},
 	}
 
 	for _, testcase := range testcases {
