fix: template version replacement & metadata updates (#58)

ethanndickson · web-flow · commit 5c965e82d299 · 2024-08-07T15:57:46.000+10:00
diff --git a/docs/resources/template.md b/docs/resources/template.md
@@ -24,8 +24,8 @@ A Coder template
 
 - `acl` (Attributes) Access control list for the template. Requires an enterprise Coder deployment. If null, ACL policies will not be added or removed by Terraform. (see [below for nested schema](#nestedatt--acl))
 - `activity_bump_ms` (Number) The activity bump duration for all workspaces created from this template, in milliseconds. Defaults to one hour.
-- `allow_user_auto_start` (Boolean) Whether users can auto-start workspaces created from this template. Defaults to true.
-- `allow_user_auto_stop` (Boolean) Whether users can auto-start workspaces created from this template. Defaults to true.
+- `allow_user_auto_start` (Boolean) Whether users can auto-start workspaces created from this template. Defaults to true. Requires an enterprise Coder deployment.
+- `allow_user_auto_stop` (Boolean) Whether users can auto-start workspaces created from this template. Defaults to true. Requires an enterprise Coder deployment.
 - `allow_user_cancel_workspace_jobs` (Boolean) Whether users can cancel in-progress workspace jobs using this template. Defaults to true.
 - `auto_start_permitted_days_of_week` (Set of String) List of days of the week in which autostart is allowed to happen, for all workspaces created from this template. Defaults to all days. If no days are specified, autostart is not allowed. Requires an enterprise Coder deployment.
 - `auto_stop_requirement` (Attributes) The auto-stop requirement for all workspaces created from this template. Requires an enterprise Coder deployment. (see [below for nested schema](#nestedatt--auto_stop_requirement))
@@ -55,7 +55,7 @@ Optional:
 
 - `active` (Boolean) Whether this version is the active version of the template. Only one version can be active at a time.
 - `message` (String) A message describing the changes in this version of the template. Messages longer than 72 characters will be truncated.
-- `name` (String) The name of the template version. Automatically generated if not provided.
+- `name` (String) The name of the template version. Automatically generated if not provided. If provided, the name *must* change each time the directory contents are updated.
 - `provisioner_tags` (Attributes Set) Provisioner tags for the template version. (see [below for nested schema](#nestedatt--versions--provisioner_tags))
 - `tf_vars` (Attributes Set) Terraform variables for the template version. (see [below for nested schema](#nestedatt--versions--tf_vars))
 
diff --git a/go.mod b/go.mod
@@ -16,6 +16,7 @@ require (
 	github.com/hashicorp/terraform-plugin-go v0.23.0
 	github.com/hashicorp/terraform-plugin-log v0.9.0
 	github.com/hashicorp/terraform-plugin-testing v1.9.0
+	github.com/otiai10/copy v1.14.0
 	github.com/stretchr/testify v1.9.0
 )
 
diff --git a/go.sum b/go.sum
@@ -339,6 +339,10 @@ github.com/opencontainers/image-spec v1.1.0 h1:8SG7/vwALn54lVB/0yZ/MMwhFrPYtpEHQ
 github.com/opencontainers/image-spec v1.1.0/go.mod h1:W4s4sFTMaBeK1BQLXbG4AdM2szdn85PY75RI83NrTrM=
 github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs=
 github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc=
+github.com/otiai10/copy v1.14.0 h1:dCI/t1iTdYGtkvCuBG2BgR6KZa83PTclw4U5n2wAllU=
+github.com/otiai10/copy v1.14.0/go.mod h1:ECfuL02W+/FkTWZWgQqXPWZgW9oeKCSQ5qVfSc4qc4w=
+github.com/otiai10/mint v1.5.1 h1:XaPLeE+9vGbuyEHem1JNk3bYc7KKqyI/na0/mLd/Kks=
+github.com/otiai10/mint v1.5.1/go.mod h1:MJm72SBthJjz8qhefc4z1PYEieWmy8Bku7CjcAqyUSM=
 github.com/outcaste-io/ristretto v0.2.3 h1:AK4zt/fJ76kjlYObOeNwh4T3asEuaCmp26pOvUOL9w0=
 github.com/outcaste-io/ristretto v0.2.3/go.mod h1:W8HywhmtlopSB1jeMg3JtdIhf+DYkLAr0VN/s4+MHac=
 github.com/pelletier/go-toml/v2 v2.2.2 h1:aYUidT7k73Pcl9nb2gScu7NSrKCSHIDE89b3+6Wq+LM=
diff --git a/integration/template-test/main.tf b/integration/template-test/main.tf
@@ -7,10 +7,15 @@ terraform {
   }
 }
 
+provider "coderd" {
+  url   = "http://localhost:3000"
+  token = "NbRNSwdzeb-Npwlm9TIOX3bpEQIsgt2KI"
+}
+
 resource "coderd_user" "ethan" {
-  username   = "ethan"
-  name       = "Ethan Coolguy"
-  email      = "test@coder.com"
+  username   = "dean"
+  name       = "Dean Coolguy"
+  email      = "deantest@coder.com"
   roles      = ["owner", "template-admin"]
   login_type = "password"
   password   = "SomeSecurePassword!"
@@ -41,8 +46,7 @@ resource "coderd_template" "sample" {
   }
   versions = [
     {
-      name      = "latest"
-      directory = "./example-template"
+      directory = "./example-template-2"
       active    = true
       tf_vars = [
         {
@@ -52,7 +56,6 @@ resource "coderd_template" "sample" {
       ]
     },
     {
-      name      = "legacy"
       directory = "./example-template-2"
       active    = false
       tf_vars = [
diff --git a/internal/provider/template_resource.go b/internal/provider/template_resource.go
diff --git a/internal/provider/template_resource_test.go b/internal/provider/template_resource_test.go

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ require (`
`16`	`16`	`github.com/hashicorp/terraform-plugin-go v0.23.0`
`17`	`17`	`github.com/hashicorp/terraform-plugin-log v0.9.0`
`18`	`18`	`github.com/hashicorp/terraform-plugin-testing v1.9.0`
	`19`	`+ github.com/otiai10/copy v1.14.0`
`19`	`20`	`github.com/stretchr/testify v1.9.0`
`20`	`21`	`)`
`21`	`22`
Original file line number	Diff line number	Diff line change
`@@ -7,10 +7,15 @@ terraform {`
`7`	`7`	`}`
`8`	`8`	`}`
`9`	`9`
	`10`	`+provider "coderd" {`
	`11`	`+ url = "http://localhost:3000"`
	`12`	`+ token = "NbRNSwdzeb-Npwlm9TIOX3bpEQIsgt2KI"`
	`13`	`+}`
	`14`	`+`
`10`	`15`	`resource "coderd_user" "ethan" {`
`11`		`- username = "ethan"`
`12`		`- name = "Ethan Coolguy"`
`13`		`- email = "test@coder.com"`
	`16`	`+ username = "dean"`
	`17`	`+ name = "Dean Coolguy"`
	`18`	`+ email = "deantest@coder.com"`
`14`	`19`	`roles = ["owner", "template-admin"]`
`15`	`20`	`login_type = "password"`
`16`	`21`	`password = "SomeSecurePassword!"`
`@@ -41,8 +46,7 @@ resource "coderd_template" "sample" {`
`41`	`46`	`}`
`42`	`47`	`versions = [`
`43`	`48`	`{`
`44`		`- name = "latest"`
`45`		`- directory = "./example-template"`
	`49`	`+ directory = "./example-template-2"`
`46`	`50`	`active = true`
`47`	`51`	`tf_vars = [`
`48`	`52`	`{`
`@@ -52,7 +56,6 @@ resource "coderd_template" "sample" {`
`52`	`56`	`]`
`53`	`57`	`},`
`54`	`58`	`{`
`55`		`- name = "legacy"`
`56`	`59`	`directory = "./example-template-2"`
`57`	`60`	`active = false`
`58`	`61`	`tf_vars = [`