Skip to content

Should we propagate template plan errors to this provider #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stirby opened this issue Sep 27, 2024 · 1 comment
Closed

Should we propagate template plan errors to this provider #109

stirby opened this issue Sep 27, 2024 · 1 comment
Labels
question Further information is requested

Comments

@stirby
Copy link

stirby commented Sep 27, 2024

A customer noticed that when the tf plan fails for a template, the coderd provider invoker fails without exposing the underlying template error.

Does it make sense to raise the Template error to our coderd provider? Otherwise, they have to debug the template in a separate context.

Template Error:
coder_ui_error

What the coderd provider invoker shows:
coderd_error
@stirby stirby added enhancement question Further information is requested labels Sep 27, 2024
@ethanndickson
Copy link
Member

The original intention was that users could stream logs from the provisioner by setting TF_LOG to info, but the UX there still kinda sucked. #95 now has the logs get dumped on error, which seems much better. It'll be in the release this week.

(I probably should've made a patch with it earlier, instead of holding off until the next Coder release)

@matifali matifali added bug and removed enhancement labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matifali @ethanndickson @stirby