fix microsoft#136362

meganrogge · meganrogge · commit 3d6c93b5e3ba · 2021-11-03T17:43:46.000-07:00
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalProfileService.ts b/src/vs/workbench/contrib/terminal/browser/terminalProfileService.ts
@@ -83,10 +83,7 @@ export class TerminalProfileService implements ITerminalProfileService {
 
 	_serviceBrand: undefined;
 
-	getDefaultProfileName(): string {
-		if (!this._defaultProfileName) {
-			throw new Error('no default profile');
-		}
+	getDefaultProfileName(): string | undefined {
 		return this._defaultProfileName;
 	}
 
diff --git a/src/vs/workbench/contrib/terminal/common/terminal.ts b/src/vs/workbench/contrib/terminal/common/terminal.ts
@@ -63,7 +63,7 @@ export interface ITerminalProfileService {
 	readonly contributedProfiles: IExtensionTerminalProfile[];
 	readonly profilesReady: Promise<void>;
 	refreshAvailableProfiles(): void;
-	getDefaultProfileName(): string;
+	getDefaultProfileName(): string | undefined;
 	onDidChangeAvailableProfiles: Event<ITerminalProfile[]>;
 	getContributedDefaultProfile(shellLaunchConfig: IShellLaunchConfig): Promise<IExtensionTerminalProfile | undefined>;
 	registerContributedProfile(extensionIdentifier: string, id: string, title: string, options: ICreateContributedTerminalProfileOptions): Promise<void>;

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,7 @@ export class TerminalProfileService implements ITerminalProfileService {`
`83`	`83`
`84`	`84`	`_serviceBrand: undefined;`
`85`	`85`
`86`		`- getDefaultProfileName(): string {`
`87`		`- if (!this._defaultProfileName) {`
`88`		`- throw new Error('no default profile');`
`89`		`- }`
	`86`	`+ getDefaultProfileName(): string \| undefined {`
`90`	`87`	`return this._defaultProfileName;`
`91`	`88`	`}`
`92`	`89`