Skip to content

Commit f5c258d

Browse files
committed
Pass credentials. Fix manifest path.
1 parent e657313 commit f5c258d

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

src/vs/code/browser/workbench/workbench-dev.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
<!-- Workbench Icon/Manifest/CSS -->
2121
<link rel="icon" href="./favicon.ico" type="image/x-icon" />
22-
<link rel="manifest" href="./manifest.json">
22+
<link rel="manifest" href="./manifest.json" crossorigin="use-credentials">
2323
<meta name="theme-color" content="{{CLIENT_BACKGROUND_COLOR}}">
2424

2525
<!-- Workbench Configuration -->

src/vs/code/browser/workbench/workbench.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
<!-- Workbench Icon/Manifest/CSS -->
1717
<link rel="icon" href="./favicon.ico" type="image/x-icon" />
18-
<link rel="manifest" href="./manifest.json">
18+
<link rel="manifest" href="./manifest.json" crossorigin="use-credentials">
1919
<meta name="theme-color" content="{{CLIENT_BACKGROUND_COLOR}}">
2020
<link data-name="vs/workbench/workbench.web.api" rel="stylesheet" href="./static/out/vs/workbench/workbench.web.api.css">
2121

src/vs/server/services/incomingHttpRequestService.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,11 +211,15 @@ export class IncomingHTTPRequestService extends AbstractIncomingRequestService<W
211211
private $webManifest: WebRequestListener = async (req, res) => {
212212
const { productConfiguration } = await this.environmentService.createWorkbenchWebConfiguration(req);
213213
const clientTheme = await this.fetchClientTheme();
214+
const startUrl = req.pathPrefix.substring(
215+
0,
216+
req.pathPrefix.lastIndexOf('/') + 1
217+
);
214218

215219
const webManifest: WebManifest = {
216220
name: productConfiguration.nameLong!,
217221
short_name: productConfiguration.nameShort!,
218-
start_url: req.pathPrefix,
222+
start_url: normalize(startUrl),
219223
display: 'fullscreen',
220224
'background-color': clientTheme.backgroundColor,
221225
description: 'Run editors on a remote server.',

0 commit comments

Comments
 (0)