Add readonly to workspace arrays

code-asher · code-asher · commit 1b6840d69a9b · 2024-05-09T14:56:51.000-08:00
This was a change in coder/coder.
diff --git a/src/api-helper.ts b/src/api-helper.ts
@@ -11,7 +11,7 @@ export function errToStr(error: unknown, def: string) {
   return def
 }
 
-export function extractAllAgents(workspaces: Workspace[]): WorkspaceAgent[] {
+export function extractAllAgents(workspaces: readonly Workspace[]): WorkspaceAgent[] {
   return workspaces.reduce((acc, workspace) => {
     return acc.concat(extractAgents(workspace))
   }, [] as WorkspaceAgent[])
diff --git a/src/commands.ts b/src/commands.ts
@@ -238,7 +238,7 @@ export class Commands {
       quickPick.value = "owner:me "
       quickPick.placeholder = "owner:me template:go"
       quickPick.title = `Connect to a workspace`
-      let lastWorkspaces: Workspace[]
+      let lastWorkspaces: readonly Workspace[]
       quickPick.onDidChangeValue((value) => {
         quickPick.busy = true
         getWorkspaces({
diff --git a/src/workspaceAction.ts b/src/workspaceAction.ts
@@ -21,14 +21,14 @@ export class WorkspaceAction {
   #POLL_INTERVAL: number = 1000 * 5
   #fetchWorkspacesInterval?: ReturnType<typeof setInterval>
 
-  #ownedWorkspaces: Workspace[] = []
+  #ownedWorkspaces: readonly Workspace[] = []
   #workspacesApproachingAutostop: NotifiedWorkspace[] = []
   #workspacesApproachingDeletion: NotifiedWorkspace[] = []
 
   private constructor(
     private readonly vscodeProposed: typeof vscode,
     private readonly storage: Storage,
-    ownedWorkspaces: Workspace[],
+    ownedWorkspaces: readonly Workspace[],
   ) {
     this.#ownedWorkspaces = ownedWorkspaces
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export function errToStr(error: unknown, def: string) {`
`11`	`11`	`return def`
`12`	`12`	`}`
`13`	`13`
`14`		`-export function extractAllAgents(workspaces: Workspace[]): WorkspaceAgent[] {`
	`14`	`+export function extractAllAgents(workspaces: readonly Workspace[]): WorkspaceAgent[] {`
`15`	`15`	`return workspaces.reduce((acc, workspace) => {`
`16`	`16`	`return acc.concat(extractAgents(workspace))`
`17`	`17`	`}, [] as WorkspaceAgent[])`