fix featureset.CoderExtension to be sematically correct

bcpeinhardt · bcpeinhardt · commit 86067f84357e · 2024-07-26T00:42:17.000Z
diff --git a/src/featureSet.ts b/src/featureSet.ts
@@ -10,8 +10,12 @@ export type FeatureSet = {
  */
 export function featureSetForVersion(version: semver.SemVer | null): FeatureSet {
   return {
-    coderExtension:
-      version?.major === 0 && version?.minor <= 14 && version?.patch < 1 && version?.prerelease.length === 0,
+    coderExtension: !(
+      version?.major === 0 &&
+      version?.minor <= 14 &&
+      version?.patch < 1 &&
+      version?.prerelease.length === 0
+    ),
 
     // CLI versions before 2.3.3 don't support the --log-dir flag!
     // If this check didn't exist, VS Code connections would fail on
diff --git a/src/remote.ts b/src/remote.ts
@@ -213,19 +213,15 @@ export class Remote {
 
     let version: semver.SemVer | null = null
     try {
-      let v = await cli.version(binaryPath)
-      if (!v) {
-        v = buildInfo.version
-      }
-      version = semver.parse(v)
+      version = semver.parse(await cli.version(binaryPath))
     } catch (e) {
       version = semver.parse(buildInfo.version)
     }
 
     const featureSet = featureSetForVersion(version)
 
     // Server versions before v0.14.1 don't support the vscodessh command!
-    if (featureSet.coderExtension) {
+    if (!featureSet.coderExtension) {
       await this.vscodeProposed.window.showErrorMessage(
         "Incompatible Server",
         {
