fix: resolve ESLint @typescript-eslint/require-await errors

jaggederest · claude · jaggederest · commit a2d2bc8eedba · 2025-06-17T18:22:07.000-07:00
- Add parserOptions.project to enable type-aware linting - Disable @typescript-eslint/require-await rule for markdown files - Remove unnecessary async keywords from functions without await 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -3,7 +3,8 @@
 	"parser": "@typescript-eslint/parser",
 	"parserOptions": {
 		"ecmaVersion": 6,
-		"sourceType": "module"
+		"sourceType": "module",
+		"project": "./tsconfig.json"
 	},
 	"plugins": ["@typescript-eslint", "prettier"],
 	"extends": [
@@ -17,7 +18,10 @@
 	"overrides": [
 		{
 			"files": ["*.md"],
-			"parser": "markdown-eslint-parser"
+			"parser": "markdown-eslint-parser",
+			"rules": {
+				"@typescript-eslint/require-await": "off"
+			}
 		}
 	],
 	"rules": {
diff --git a/src/api.ts b/src/api.ts
@@ -71,11 +71,11 @@ export async function createHttpAgent(): Promise<ProxyAgent> {
  * configuration.  The token may be undefined if some other form of
  * authentication is being used.
  */
-export async function makeCoderSdk(
+export function makeCoderSdk(
 	baseUrl: string,
 	token: string | undefined,
 	storage: Storage,
-): Promise<Api> {
+): Api {
 	const restClient = new Api();
 	restClient.setHost(baseUrl);
 	if (token) {
diff --git a/src/error.ts b/src/error.ts
@@ -126,7 +126,7 @@ export class CertificateError extends Error {
 	}
 
 	// allowInsecure updates the value of the "coder.insecure" property.
-	async allowInsecure(): Promise<void> {
+	allowInsecure(): void {
 		vscode.workspace
 			.getConfiguration()
 			.update("coder.insecure", true, vscode.ConfigurationTarget.Global);
diff --git a/src/util.test.ts b/src/util.test.ts
@@ -1,7 +1,7 @@
 import { describe, it, expect } from "vitest";
 import { countSubstring, parseRemoteAuthority, toSafeHost } from "./util";
 
-it("ignore unrelated authorities", async () => {
+it("ignore unrelated authorities", () => {
 	const tests = [
 		"vscode://ssh-remote+some-unrelated-host.com",
 		"vscode://ssh-remote+coder-vscode",
@@ -15,7 +15,7 @@ it("ignore unrelated authorities", async () => {
 	}
 });
 
-it("should error on invalid authorities", async () => {
+it("should error on invalid authorities", () => {
 	const tests = [
 		"vscode://ssh-remote+coder-vscode--foo",
 		"vscode://ssh-remote+coder-vscode--",
@@ -27,7 +27,7 @@ it("should error on invalid authorities", async () => {
 	}
 });
 
-it("should parse authority", async () => {
+it("should parse authority", () => {
 	expect(
 		parseRemoteAuthority("vscode://ssh-remote+coder-vscode--foo--bar"),
 	).toStrictEqual({
@@ -81,7 +81,7 @@ it("should parse authority", async () => {
 	});
 });
 
-it("escapes url host", async () => {
+it("escapes url host", () => {
 	expect(toSafeHost("https://foobar:8080")).toBe("foobar");
 	expect(toSafeHost("https://ほげ")).toBe("xn--18j4d");
 	expect(toSafeHost("https://test.😉.invalid")).toBe("test.xn--n28h.invalid");
diff --git a/src/util.ts b/src/util.ts
@@ -25,7 +25,7 @@ export const RemoteSSHLogPortRegex =
  *
  * Returns null if no port is found.
  */
-export async function findPort(text: string): Promise<number | null> {
+export function findPort(text: string): number | null {
 	const matches = text.match(RemoteSSHLogPortRegex);
 	if (!matches) {
 		return null;
diff --git a/src/workspacesProvider.ts b/src/workspacesProvider.ts
@@ -156,7 +156,7 @@ export class WorkspaceProvider
 
 		// Create tree items for each workspace
 		const workspaceTreeItems = await Promise.all(
-			resp.workspaces.map(async (workspace) => {
+			resp.workspaces.map((workspace) => {
 				const workspaceTreeItem = new WorkspaceTreeItem(
 					workspace,
 					this.getWorkspacesQuery === WorkspaceQuery.All,
@@ -235,7 +235,7 @@ export class WorkspaceProvider
 		this._onDidChangeTreeData.fire(item);
 	}
 
-	async getTreeItem(element: vscode.TreeItem): Promise<vscode.TreeItem> {
+	getTreeItem(element: vscode.TreeItem): vscode.TreeItem {
 		return element;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ export class CertificateError extends Error {`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`// allowInsecure updates the value of the "coder.insecure" property.`
`129`		`- async allowInsecure(): Promise<void> {`
	`129`	`+ allowInsecure(): void {`
`130`	`130`	`vscode.workspace`
`131`	`131`	`.getConfiguration()`
`132`	`132`	`.update("coder.insecure", true, vscode.ConfigurationTarget.Global);`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export const RemoteSSHLogPortRegex =`
`25`	`25`	`*`
`26`	`26`	`* Returns null if no port is found.`
`27`	`27`	`*/`
`28`		`-export async function findPort(text: string): Promise<number \| null> {`
	`28`	`+export function findPort(text: string): number \| null {`
`29`	`29`	`const matches = text.match(RemoteSSHLogPortRegex);`
`30`	`30`	`if (!matches) {`
`31`	`31`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ export class WorkspaceProvider`
`156`	`156`
`157`	`157`	`// Create tree items for each workspace`
`158`	`158`	`const workspaceTreeItems = await Promise.all(`
`159`		`- resp.workspaces.map(async (workspace) => {`
	`159`	`+ resp.workspaces.map((workspace) => {`
`160`	`160`	`const workspaceTreeItem = new WorkspaceTreeItem(`
`161`	`161`	`workspace,`
`162`	`162`	`this.getWorkspacesQuery === WorkspaceQuery.All,`
`@@ -235,7 +235,7 @@ export class WorkspaceProvider`
`235`	`235`	`this._onDidChangeTreeData.fire(item);`
`236`	`236`	`}`
`237`	`237`
`238`		`- async getTreeItem(element: vscode.TreeItem): Promise<vscode.TreeItem> {`
	`238`	`+ getTreeItem(element: vscode.TreeItem): vscode.TreeItem {`
`239`	`239`	`return element;`
`240`	`240`	`}`
`241`	`241`