Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/websocket
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.6
Choose a base ref
...
head repository: coder/websocket
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.7
Choose a head ref
  • 9 commits
  • 8 files changed
  • 4 contributors

Commits on Sep 22, 2020

  1. Copy http client

    swithek committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    1b61eb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Configuration menu
    Copy the full SHA
    dbaf6f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Improve http client copying

    swithek committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    f67b03b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Merge pull request #261 from swithek/copy-http-client

    Allow *http.Client with Timeout set
    nhooyr authored Oct 2, 2020
    Configuration menu
    Copy the full SHA
    b00726c View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. Configuration menu
    Copy the full SHA
    c9f314a View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. Do not lower header tokens in headerTokens() (#273)

    HTTP header values, as opposed to header keys,
    are case sensitive, but implementation of headerTokens()
    before this patch would return lowered values always.
    
    This old behavior could lead to chromium (v87) WebSocket
    rejecting connnection because negotiated subprotocol,
    returned in Sec-WebSocket-Protocol header (lowered
    be headerToken() function) would not match one sent
    by client, in case client specified value with capital
    letters.
    Egor Gorbunov authored Dec 23, 2020
    Configuration menu
    Copy the full SHA
    e4c3b0f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Fix DOS attack from malicious pongs

    A double channel close panic was possible if a peer sent back multiple
    pongs for every ping.
    
    If the second pong arrived before the ping goroutine deleted its channel
    from the map, the channel would be closed twice and so a panic would
    ensue.
    
    This fixes that by having the read goroutine send on the ping
    goroutine's channel rather than closing it.
    
    Reported via email by Tibor Kálmán @kalmant
    
    Please update to the new release ASAP!
    nhooyr committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    129d303 View commit details
    Browse the repository at this point in the history
  2. Fix CI

    nhooyr committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    b0d7a27 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #291 from nhooyr/dos-56b8

    Fix DOS attack from malicious pongs
    nhooyr authored Apr 7, 2021
    Configuration menu
    Copy the full SHA
    3604edc View commit details
    Browse the repository at this point in the history
Loading