Skip to content

Origin check should not only be a check against the host #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
timofurrer opened this issue Apr 28, 2025 · 0 comments
Open

Origin check should not only be a check against the host #529

timofurrer opened this issue Apr 28, 2025 · 0 comments

Comments

@timofurrer
Copy link

The package supports to automatically perform an Origin header check via OriginPatterns. However, these origin patterns are only checked against the Origin header Host component (see

websocket/accept.go

Line 244 in efb626b

matched, err := match(hostPattern, u.Host)
).

I believe that this is incorrect and the entire Origin header should be checked against a set of allowed once - that is, including the schema and port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timofurrer