Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/yamux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: coder/yamux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 11, 2022

  1. Fix use of unprotected stream.sendHdr in session (#1)

    We now create a new header slice instead of taking a `sendLock` as this
    is a rare occurrence.
    mafredri authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    7051340 View commit details
    Browse the repository at this point in the history
  2. Fix unsafe header re-use on close and timeout (#2)

    This commit takes a minimal approach to fixing unsafe header re-use
    during close and timeout by reallocating the header in those cases.
    
    Partially fixes: coder/coder#2429
    
    Related: #40
    mafredri authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    12254a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a58105 View commit details
    Browse the repository at this point in the history
  4. Protect reads of sendReady.Body with mutex and temp buffer (#4)

    This commit fixes an edge case where the `body` passed to
    `waitForSendErr` can be written to after returning from the function.
    This happens when `sendReady` is buffered on the `sendCh` and the
    session is shutdown or the write times out.
    
    When this condition happens and `waitForSendErr` has not yet exited, the
    `body` is safely copied into a temporary buffer in `send`. Otherwise
    `waitForSendErr` safely created a copy of the `body` and exits, this
    essentially results in double buffering for the edge case which seems
    acceptable.
    mafredri authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    ba57465 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Configuration menu
    Copy the full SHA
    7bf120a View commit details
    Browse the repository at this point in the history
Loading