order boostrap select * by pk when available

Nicolas Maquet · Nicolas Maquet · commit a2a76baf8aee · 2015-12-22T09:09:17.000+13:00
diff --git a/src/main/java/com/zendesk/maxwell/bootstrap/SynchronousBootstrapper.java b/src/main/java/com/zendesk/maxwell/bootstrap/SynchronousBootstrapper.java
@@ -68,7 +68,7 @@ public void startBootstrap(RowMap startBootstrapRow, Schema schema, AbstractProd
 		LOGGER.info(String.format("bootstrapping started for %s.%s, binlog position is %s", databaseName, tableName, position.toString()));
 		try ( Connection connection = getConnection() ) {
 			setBootstrapRowToStarted(startBootstrapRow, connection);
-			ResultSet resultSet = getAllRows(databaseName, tableName, connection);
+			ResultSet resultSet = getAllRows(databaseName, tableName, schema, connection);
 			int insertedRows = 0;
 			while ( resultSet.next() ) {
 				RowMap row = new RowMap(
@@ -165,9 +165,14 @@ private void ensureTable(String tableName, Database database) {
 		findTable(tableName, database);
 	}
 
-	private ResultSet getAllRows(String databaseName, String tableName, Connection connection) throws SQLException, InterruptedException {
+	private ResultSet getAllRows(String databaseName, String tableName, Schema schema, Connection connection) throws SQLException, InterruptedException {
 		Statement statement = createBatchStatement(connection);
-		return statement.executeQuery(String.format("select * from %s.%s", databaseName, tableName));
+		String pk = schema.findDatabase(databaseName).findTable(tableName).getPKString();
+		if ( pk != null ) {
+			return statement.executeQuery(String.format("select * from %s.%s order by %s", databaseName, tableName, pk));
+		} else {
+			return statement.executeQuery(String.format("select * from %s.%s", databaseName, tableName));
+		}
 	}
 
 	private Statement createBatchStatement(Connection connection) throws SQLException, InterruptedException {
