move ObjectInputStream initialization to call-site

Ben Osheroff · Ben Osheroff · commit c0accf3b62b5 · 2015-12-11T12:33:35.000-08:00
diff --git a/src/main/java/com/zendesk/maxwell/util/ListWithDiskBuffer.java b/src/main/java/com/zendesk/maxwell/util/ListWithDiskBuffer.java
@@ -39,11 +39,6 @@ public void add(T element) throws IOException {
 
 			os.writeUnshared(this.list.removeFirst());
 
-			if ( is == null && os != null ) {
-				os.flush();
-				is = new ObjectInputStream(new BufferedInputStream(new FileInputStream(file)));
-			}
-
 			elementsInFile++;
 		}
 	}
@@ -57,7 +52,12 @@ public T getLast() {
 	}
 
 	public T removeFirst() throws IOException, ClassNotFoundException {
-		if ( elementsInFile > 0 && is != null ) {
+		if ( elementsInFile > 0 ) {
+			if ( is == null ) {
+				os.flush();
+				is = new ObjectInputStream(new BufferedInputStream(new FileInputStream(file)));
+			}
+
 			T element = (T) is.readUnshared();
 			elementsInFile--;
 			return element;
