Minor updates

coder137 · coder137 · commit fa3811d439fe · 2021-11-18T04:18:35.000-08:00
diff --git a/buildcc/lib/target/include/target/common/target_state.h b/buildcc/lib/target/include/target/common/target_state.h
@@ -22,21 +22,20 @@
 namespace buildcc::base {
 
 // TODO, Seperate TargetState into lock_ and other internal boolean variables
+// NOTE, This is because apart from lock_ every other parameter is updated
+// during `Target::Build`
+// TargetInfo does not have a `Build` method, it is only meant to hold
+// information
 struct TargetState {
   void SetSourceState(TargetFileExt file_extension);
   void SetPch();
   void SetLock();
 
   void ExpectsUnlock() const;
   void ExpectsLock() const;
+  // TODO, IsLocked
 
   bool ContainsPch() const { return contains_pch_; }
-  // TODO, ContainsAsm
-  // TODO, ContainsC
-  // TODO, ContainsCpp
-
-  // TODO, IsLocked
-  // TODO, IsBuilt
 
   // TODO, Make these private getters
   bool contains_asm{false};
diff --git a/buildcc/lib/target/include/target/target.h b/buildcc/lib/target/include/target/target.h
@@ -155,7 +155,10 @@ class Target : public BuilderInterface, public TargetInfo {
   // Fbs
   bool Store() override;
 
-  // Callbacks
+  // Tasks
+  void TaskDeps();
+
+  // Callbacks for unit tests
   void SourceRemoved();
   void SourceAdded();
   void SourceUpdated();
@@ -167,15 +170,13 @@ class Target : public BuilderInterface, public TargetInfo {
   void FlagChanged();
   void ExternalLibChanged();
 
-  void TaskDeps();
-
 private:
   std::string name_;
   TargetType type_;
   const Toolchain &toolchain_;
   internal::TargetLoader loader_;
 
-  // Friend
+  // Friend classes
   CompilePch compile_pch_;
   CompileObject compile_object_;
   LinkTarget link_target_;
