dispatcher: if connection pool is already initialized raise exception

tsnoam · tsnoam · commit 3608c2bbe515 · 2016-06-01T22:30:34.000+03:00
this will better protect the user from wrong usage
diff --git a/telegram/ext/dispatcher.py b/telegram/ext/dispatcher.py
@@ -24,6 +24,8 @@
 from time import sleep
 from queue import Queue, Empty
 
+from future.builtins import range
+
 from telegram import (TelegramError, NullHandler)
 from telegram.utils import request
 from telegram.ext.handler import Handler
@@ -109,8 +111,9 @@ def __init__(self, bot, update_queue, workers=4, exception_event=None):
         self.__exception_event = exception_event or Event()
 
         if not len(ASYNC_THREADS):
-            if request._CON_POOL:
-                self.logger.warning("Connection Pool already initialized!")
+            if request.is_con_pool_initialized():
+                raise RuntimeError('Connection Pool already initialized')
+
             request.CON_POOL_SIZE = workers + 3
             for i in range(workers):
                 thread = Thread(target=_pooled, name=str(i))
diff --git a/telegram/utils/request.py b/telegram/utils/request.py
@@ -47,6 +47,9 @@ def _get_con_pool():
         ])
     return _CON_POOL
 
+def is_con_pool_initialized():
+    return _CON_POOL is not None
+
 
 def _parse(json_data):
     """Try and parse the JSON returned from Telegram.
