fix/hack Updater.stop() not working on extreme cases

tsnoam · tsnoam · commit 881d1d0e25d4 · 2016-06-17T23:53:18.000+03:00
during test_bootstrap_retries_fail() there is an exception raised (by
design): TelegramError('test')

For a reason I haven't managed to pinpoint the above exception in its
precise timing caused the Updater to be left in a state which is
'self.running == False', but the dispatcher threads already initialized.
This patch identifies this extreme case and makes sure to go over the
stop procedure.
diff --git a/telegram/ext/updater.py b/telegram/ext/updater.py
@@ -346,7 +346,7 @@ def stop(self):
 
         self.job_queue.stop()
         with self.__lock:
-            if self.running:
+            if self.running or dispatcher.ASYNC_THREADS:
                 self.logger.debug('Stopping Updater and Dispatcher...')
 
                 self.running = False
